Joe Hannon's profile

Joe Hannon commented at 8:12 AM
Rails' inability to automatically route my link_to and form_for in STI subclasses to the superclass is a constant source of frustration to me. +1 for fixing thi...

Joe Hannon commented at 5:22 AM
I redid the new patch so that it puts the new method at the top of the conflict, instead of below it, so that it matches the commit you made to master. Probably...
Joe Hannon commented at 2:00 AM
PS is it weird that patch can apply the diff cleanly, but git-am cannot?
Joe Hannon commented at 1:50 AM
Attachment hmt_self_join_alias_30stable_safe.diff
Joe Hannon commented at 1:48 AM
Ok Aaron. I think I've fixed the patch to work on 3-0-stable. The merge conflict was trivial (the patch file was expecting the method above HasManyThroughAssoci...

Joe Hannon commented at 7:41 AM

I'm not too sure of my git usage, so I tried directly downloading from github. Still works fine for me. See screengrab:

http://twitpic.com/3g2uf2
Joe Hannon commented at 7:35 AM

@Aaron Yeah, it looks like you're applying the right patch. Am I applying the patch to the right codebase?

Here's what I'm doing (sorry, no music):

git clone ht...
Joe Hannon commented at 6:16 AM

@Aaron Oh yes, I see your commit now, including Ernie's patch.

Anyway, I'm not sure what you mean about it not applying cleanly. I've tried it on 3-0-stable and...
Joe Hannon commented at 12:58 AM
Aaron, my original unit test had a mistake in it, so it will fail. Ernie's patch includes the table aliasing fix, but also includes a fix for my unit test. Did ...