Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Piotr Sarnacki's latest activity

Sunday, December 19 2010
6188 Model name for default submit button value should be titleized was updated in Ruby on Rails
  • Piotr Sarnacki
    Piotr Sarnacki commented at 9:38 AM

    Samuel: Yes, but this patch is about sensible default.

    I would rather say that it should be "Create ticket type" instead of "Create Ticket Type" or "Create Tick...

Saturday, December 18 2010
5847 Rails 3.0.1 - config.action_view.cache_template_loading is missing was updated in Ruby on Rails
  • Piotr Sarnacki
    Piotr Sarnacki commented at 9:07 AM

    José Valim: thanks for clarification!

  • Piotr Sarnacki
    Piotr Sarnacki commented at 8:39 AM

    Robert: Thanks!

    Although the patch is already applied, I will look into Eric's issue with clearing view paths cache, maybe it could be cleared by default in dev...

6040 ActiveSupport - Incorrect Inflectors for "nurseries" was updated in Ruby on Rails
  • Piotr Sarnacki
    • State changed from new to duplicate
    • Importance changed from to Low
    by Piotr Sarnacki at 8:54 AM

    I know that this was first, but the other ticket has a patch, so it will be easier to discuss there. Closing as duplicate.

6093 [PATCH] Uncountable singularize uses regex match while pluralize uses exact m... was updated in Ruby on Rails
  • Piotr Sarnacki
    Piotr Sarnacki commented at 8:53 AM

    John: only one thing, you should move the last line of second test to ensure:

    ensure
      ActiveSupport::Inflector.inflections.instance_variable_set :@uncountable...
Friday, December 17 2010
6184 'rails server' command ignores BUNDLE_GEMFILE was updated in Ruby on Rails
6187 PostgreSQL and Rails 3.0.3 migrations fail with index name length > 64 chars was updated in Ruby on Rails
  • Piotr Sarnacki
    • Assigned user set to Piotr Sarnacki
    by Piotr Sarnacki at 6:49 PM

    fhirzall: I checked history for changes in that matter and it looks like:

    rails < 2.3.4 didn't care
    2.3.4 <= rails < 2.3.6 - exception caused by #3252
    2.3.6 <= ...

  • Piotr Sarnacki
    • State changed from invalid to open
    by Piotr Sarnacki at 4:14 PM

    I would personally leave it out like that, but I can see your point. If it was fixed earlier in 2.3, I'm opening that ticket for further discussion.

  • Piotr Sarnacki
    • State changed from incomplete to invalid
    by Piotr Sarnacki at 2:55 PM
6182 Another rounding problem in number_with_precision was updated in Ruby on Rails
  • Piotr Sarnacki
    • Milestone cleared.
    • State changed from resolved to open
    • Assigned user set to Piotr Sarnacki
    by Piotr Sarnacki at 3:16 PM

    Awww... sorry guys, I accidently applied that to master and pushed with other fix. I've reverted it now, so it's still open.

    Don: please let me know on your fin...