Piotr Sarnacki
Member of 1 project: Ruby on Rails
Piotr Sarnacki's latest activity
Sunday, December 19 2010
-
Piotr Sarnacki commented at 9:38 AMSamuel: Yes, but this patch is about sensible default.
I would rather say that it should be "Create ticket type" instead of "Create Ticket Type" or "Create Tick...
Saturday, December 18 2010
-
-
Piotr Sarnacki commented at 8:39 AMRobert: Thanks!
Although the patch is already applied, I will look into Eric's issue with clearing view paths cache, maybe it could be cleared by default in dev...
-
- State changed from new to duplicate
- Importance changed from to Low
I know that this was first, but the other ticket has a patch, so it will be easier to discuss there. Closing as duplicate.
-
Piotr Sarnacki commented at 8:53 AMJohn: only one thing, you should move the last line of second test to ensure:
ensure ActiveSupport::Inflector.inflections.instance_variable_set :@uncountable...
Friday, December 17 2010
-
Piotr Sarnacki commented at 9:25 PMSamuel: I've already rebuilt the boot.rb file to use "require 'bundler/setup'", this is the preferred way to do that: https://github.com/rails/rails/commit/064...
-
- Assigned user set to Piotr Sarnacki
fhirzall: I checked history for changes in that matter and it looks like:
rails < 2.3.4 didn't care
2.3.4 <= rails < 2.3.6 - exception caused by #3252
2.3.6 <= ... -
- State changed from invalid to open
I would personally leave it out like that, but I can see your point. If it was fixed earlier in 2.3, I'm opening that ticket for further discussion.
-
-
- Milestone cleared.
- State changed from resolved to open
- Assigned user set to Piotr Sarnacki
Awww... sorry guys, I accidently applied that to master and pushed with other fix. I've reverted it now, so it's still open.
Don: please let me know on your fin...