This project is archived and is in readonly mode.
[Patch] Model name for default submit button value should be titleized
-
Ben Mills- No changes were found…
-
Johnneylee Jack Rollins+1 Makes a good bunch of sense to me.
-
Ben Mills
Updated the patch to just titleize model regardless of what the conditions returns
-
-
Ben Mills
Updated patch to provide a test
-
Ben Mills
Cleaned up unnecessary code in patch test
-
Samuel Kadolph
Patch seems logical. However it is currently possible to fix this with localization.
en: activerecord: models: ticket_type: Ticket Type -
Piotr SarnackiSamuel: Yes, but this patch is about sensible default.
I would rather say that it should be "Create ticket type" instead of "Create Ticket Type" or "Create Ticket type". Is "titleize" the convention in other places in forms?
-
esparkman
+1 this makes sense to me as well.
-
salbito
+1 aswell Makes sense as a default avoids having to do this in localization files for every instance of this situation.
-
Ben Mills
Can we get this merged in, please?
-
Dan Pickett- Title changed from Model name for default submit button value should be titleized to [Patch] Model name for default submit button value should be titleized
- Tag changed from actionview, action_view, formbuilder, submit to actionview, action_view, formbuilder, patch, submit
+1 this is a much better default.
one of the patch's tests fails on master due to dropping the id on submit inputs in form_for
I've patched the regression and Ben's original authorship should be maintained.
