Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Jan Berkel

Jan Berkel

Not a member

Jan Berkel's latest activity

Tuesday, June 29 2010
4762 url_for :escape parameter is ignored was updated in Ruby on Rails
  • Jan Berkel
    • Importance changed from to High
    by Jan Berkel at 11:08 AM

    thanks! i backported the fix to 2-3-stable. any chance this can be applied? we're not ready for 3.x yet.
Friday, June 04 2010
4762 url_for :escape parameter is ignored was updated in Ruby on Rails
  • Jan Berkel
    Jan Berkel commented at 1:41 AM

    @neeraj: anchor tags are not even sent to the server, they are purely local. it still makes sense to escape the anchor tag to produce valid urls, but the conten...
Thursday, June 03 2010
4762 url_for :escape parameter is ignored was updated in Ruby on Rails
  • Jan Berkel
    Jan Berkel commented at 10:33 PM

    that issue is unrelated. the problem is in actionpack/lib/action_dispatch/routing/route_set.rb:

    
# route_set.rb
def url_for(options)
  ...
  rewritten_url << "...
  • Jan Berkel
    Jan Berkel created the ticket at 6:42 PM

    The rdoc for url_for in actionpack/lib/action_view/helpers/url_helper.rb states:

       url_for(:action => 'checkout', :anchor => 'tax&ship', :escape => false) 
  ...