Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Fjan's latest activity

Friday, April 29 2011
4858 [PATCH] ActionMailer is html escaping plain text messages was updated in Ruby on Rails
  • Fjan
    Fjan commented at 8:15 AM

    @Matthew: I've been using the monkey patch I provided in the November 11th post in production for quite some time now and it works great. Just drop it in the co...

Sunday, January 09 2011
6022 Content negotiation fails for some */* headers (regression) was updated in Ruby on Rails
  • Fjan
    Fjan commented at 9:13 AM

    Yes, I actually ended up using the monkey patch above that just return the HTML template if no other is available. There are just to many odd headers out there.

Thursday, December 16 2010
1485 json_escape eats away double quotes was updated in Ruby on Rails
  • Fjan
    Fjan commented at 10:59 AM

    @Michael Koziarski "It returns the strings without dangerous characters"

    That's not quite true:
    json_escape('hi \"now\"') # => 'hi \now\'

    This will insert a spu...

Tuesday, December 07 2010
6002 [PATCH] Ignore domain :all option if host is IP address or localhost was updated in Ruby on Rails
  • Fjan
    Fjan commented at 10:30 AM

    @Ravil, you are right, I stand corrected. Would be nice if we can think of a regex that does both checks in one go though.

Monday, December 06 2010
6002 [PATCH] Ignore domain :all option if host is IP address or localhost was updated in Ruby on Rails
  • Fjan
    Fjan commented at 3:51 PM

    The patch still sets an illegal cookie domain name on localhost, you could improve it a little bit by checking @host =~ /\w.[a-z]\w/i
    this will make sure there ...

6120 Flash message don't clear was updated in Ruby on Rails
  • Fjan
    Fjan commented at 3:40 PM

    Could it be that there is still a cookie on the system from before you set :domain => all? If that's the case then the browser will send both session cookies an...

Friday, December 03 2010
6111 Sessions should not be saved unless dirty [patch] was updated in Ruby on Rails
  • Fjan
    Fjan commented at 1:23 PM

    Just a small clarification on the obscure IE7 bug in case people want to reproduce it: It only happens in combination with Apache which (correctly) filters P3P ...

  • Fjan
    Fjan created the ticket at 1:01 PM

    At the moment Rails saves sessions after every request that access the (lazy loaded) session, even if the session has not changed. This has two problems:

    1. Perfo...
4450 'expire_after' option on session forces session creation on each and every ac... was updated in Ruby on Rails
  • Fjan
    Fjan commented at 1:04 PM

    I agree that this patch is a good idea but I think we should go one step further and only update the session if it has both been accessed AND been changed, see ...

Thursday, December 02 2010
4818 Share session between subdomains was updated in Ruby on Rails
  • Fjan
    Fjan commented at 4:34 PM

    This patch doe produce a cookie that doesn't conform to specs if the host you are accessing is "localhost" or an IP address. The browsers I tried don't seem to ...