Fjan's profile

Fjan commented at 11:22 AM
The incorrect behaviour is still in Rails 3.0.3. So <%=j @person.to_json %> is still in the 3.0.3 docs and still produces invalid output. Do we need a new ticke...

- Title changed from ActionMailer is html escaping plain text messages to [PATCH] ActionMailer is html escaping plain text messages
by Fjan at 4:40 PM
Here is the one-line patch that can be applied to edge. Sorry, I have no idea how to add a test for this, I'm kind of new to all this.
Fjan commented at 3:25 PM
Now that my patch to add a non-escaping option to Erubis has been committed to 3.0 stable this problem can be fixed by simply letting the handler check if the ...

Fjan commented at 2:44 PM
And here is a test to go with it.
- Title changed from Fix Erubis non-escaping sequence [patch] to [PATCH] Fix Erubis non-escaping sequence to mimic raw()
by Fjan at 2:44 PM
Ok, here's the patch. This is my first experience with git and with submitting a patch. I think I followed the procedures in the Rails guide correctly but pleas...

Fjan created the ticket at 4:42 PM
According to the Erubis documentation the sequence <%== %> should insert the contents without HTML escaping. At the moment Rails instead produces double escaped...

Fjan commented at 11:24 PM
You are right. Sorry for the spam here, not thinking to clearly after typing 390 html_safes. I'll put in a new ticket tomorrow.
- Title changed from ActionMailer is html escaping ampersand (&) in Urls in plain text messages to ActionMailer is html escaping plain text messages
by Fjan at 11:17 PM

Fjan commented at 11:16 PM

Oops, that method in my first posts should have read:

def add_expr_escaped(src, code)
  src << "@output_buffer.safe_concat((" << code << ").to_s);"
end

Also a...

Fjan commented at 9:07 PM

I agree a proper fix where plain text templates do net get escaped would be better.

However, I still like that new syntax for the regular views. I just did a qu...