Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Denis Odorcic

Denis Odorcic

Not a member

Denis Odorcic's latest activity

Wednesday, October 27 2010
5861 find_each and find_in_batches assumes that primary key is a number was updated in Ruby on Rails
  • Denis Odorcic
    Denis Odorcic commented at 1:54 AM

    From the comments:

    # It's not possible to set the order. That is automatically set to
# ascending on the primary key ("id ASC") to make the batch ordering
# wo...
Tuesday, October 26 2010
5868 Rails3 ActionView erroneous deprecation warnings was updated in Ruby on Rails
  • Denis Odorcic
    Denis Odorcic commented at 11:11 PM

    Setting

    <%- content_tag :h2, :header do -%>
    to
    <%= content_tag :h2, :header do -%>
    works fine for me. Make sure not to include an <%= on the <% end %>
Saturday, October 23 2010
5850 ActiveSupport::Cache::FileStore: undefined method `ord' for nil:NilClass was updated in Ruby on Rails
  • Denis Odorcic
    • Tag changed from activesupport, caching, file_store, rails3.0.0, rails3.0.1 to activesupport, caching, file_store, patch, rails3.0.0, rails3.0.1
    by Denis Odorcic at 9:54 PM
  • Denis Odorcic
    Denis Odorcic commented at 7:04 AM

    Attached is a patch and failing test.

    The issue was that with FileStore, the key is the filename, which was being escaped properly, but not unescaped. This only...
5859 Nested objects return extra nil array was updated in Ruby on Rails
  • Denis Odorcic
    Denis Odorcic commented at 4:05 AM

    Can't reproduce unfortunately, anyone else?
Friday, October 22 2010
5605 Using Model.includes(:relation_with_custom_primary_key) was updated in Ruby on Rails
  • Denis Odorcic
    Denis Odorcic commented at 6:01 AM

    Added one-liner so whatever the committer prefers
Thursday, October 21 2010
5605 Using Model.includes(:relation_with_custom_primary_key) was updated in Ruby on Rails
  • Denis Odorcic
    Denis Odorcic commented at 3:11 PM

    I can update the patch tonight if the one-liner is the preferred method.
  • Denis Odorcic
    • Tag set to patch
    by Denis Odorcic at 5:29 AM

    Attached a failing test and fix. It was only comparing strings, so if you pass in a symbol to :primary_key it'll fail.
Sunday, March 28 2010
4278 Objects lose association methods in development mode was updated in Ruby on Rails
  • Denis Odorcic
    • Tag changed from associations, caching, development to associations, caching, default_scope, development
    by Denis Odorcic at 4:13 AM

    So I've narrowed down the issue to it being because of default_scope
    When I comment out the default_scope in comments it works fine, when its not commented out,...
Saturday, March 27 2010
4278 Objects lose association methods in development mode was created in Ruby on Rails
  • Denis Odorcic
    Denis Odorcic created the ticket at 12:24 AM

    I'm hoping someone else might've encountered this and could chime in, since I can't reproduce the problem with tests.

    I have an app that's currently using Rails...