Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Federico Brubacher

Federico Brubacher

Not a member

Federico Brubacher's latest activity

Saturday, May 15 2010
2919 Activerecord::Base#clone does not set dirty bits was updated in Ruby on Rails
  • Federico Brubacher
    • Tag changed from activemodel, bugmash, dirty, patch to activemodel, bugmash-review, dirty, patch
    by Federico Brubacher at 9:24 PM
  • Federico Brubacher
    Federico Brubacher commented at 8:05 PM

    Pleax if you read the thread in this ticket you will see what is the behavior that is bugging me and some of the other users.

    What the thread starter and Armit ...
  • Federico Brubacher
    • Tag changed from activemodel, bugmash, dirty to activemodel, bugmash, dirty, patch
    by Federico Brubacher at 6:00 PM

    I've attached a patch.

    I agree with Arpit, from the docs: Cloned objects have no id assigned and are treated as new records

    Here is a patch that fixes this beha...
4556 When using conditional layouts, actions fallback to parent layout was updated in Ruby on Rails
  • Federico Brubacher
    Federico Brubacher commented at 3:04 PM

    You are right, it is easier to use the workaround that you provided.
  • Federico Brubacher
    • Tag changed from 3.0, actionpack, layout, patch to 3.0, actionpack, bugmash, layout, patch
    • Assigned user changed from Santiago Pastorino to José Valim
    by Federico Brubacher at 3:59 AM

    There has been some going back and forth with Santiago and some lessons learned about this.

    First of all, my main selling point for this patch is that the bug t...
Tuesday, May 11 2010
4556 When using conditional layouts, actions fallback to parent layout was updated in Ruby on Rails
  • Federico Brubacher
    Federico Brubacher commented at 7:35 PM

    Santiago, I merged both patches into one ask requested.
  • Federico Brubacher
    • Tag changed from patch to 3.0, patch
    by Federico Brubacher at 3:26 PM

    Thanks Diego for your patch, I like your changes because it seems that the notation fits better with the rest part of the code.
2896 collection_singular_ids breaks when used with :include was updated in Ruby on Rails
  • Federico Brubacher
    Federico Brubacher commented at 1:26 AM

    The last patch looks much better than the first time, i ran the tests on latest version of master and so far so good. It seems a issue worth fixing.
    +1
Saturday, May 08 2010
3619 Conditional layouts ignore default application wide layout was updated in Ruby on Rails
  • Federico Brubacher
    Federico Brubacher commented at 9:39 PM

    Hey guys, I made other ticket with a more limited scope, but I agree with Fernando we should have more flexibility and even ability to add 2+ layout declaration...
4556 When using conditional layouts, actions fallback to parent layout was updated in Ruby on Rails
  • Federico Brubacher
    Federico Brubacher commented at 9:35 PM

    I will also try to back-port the fix for it to work in 2-3.stable.