Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Federico Brubacher

Federico Brubacher

Not a member

Federico Brubacher's latest activity

Friday, April 22 2011
5400 ActiveRecord::Serialization.serializable_hash uses base :only/:expect for inc... was updated in Ruby on Rails
  • Federico Brubacher
    Federico Brubacher commented at 1:28 PM

    Santiago, Jeremy have you guys been able to review this patch ?
Wednesday, March 30 2011
5400 ActiveRecord::Serialization.serializable_hash uses base :only/:expect for inc... was updated in Ruby on Rails
  • Federico Brubacher
    • Tag set to json activerecord serialization
    • Assigned user set to Santiago Pastorino
    by Federico Brubacher at 11:23 AM
Sunday, May 16 2010
4614 Cloned object mimic changed_attributes from creator after being clonde was updated in Ruby on Rails
  • Federico Brubacher
    Federico Brubacher commented at 3:51 PM

    Jose, here is the patch with marked attributes as public
  • Federico Brubacher
    • Tag changed from 3.0, activerecord, dirty, patch to 3.0, activerecord, bugmash, dirty, patch
    by Federico Brubacher at 2:37 PM
  • Federico Brubacher
    • Tag changed from 3.0, activerecord, dirty to 3.0, activerecord, dirty, patch
    by Federico Brubacher at 2:36 PM
  • Federico Brubacher
    • Tag changed from 3.0, activerecord, bugmash, dirty to 3.0, activerecord, dirty
    by Federico Brubacher at 2:35 PM

    I've attached a patch.

    This patch includes the test case that no longer fails and a fix.
  • Federico Brubacher
    Federico Brubacher created the ticket at 11:29 AM

    After creating a clone , when changing an attribute in either the parent or the clone, both objects are marked as changed.

    Here's a failing test.
2919 Activerecord::Base#clone does not set dirty bits was updated in Ruby on Rails
  • Federico Brubacher
    Federico Brubacher commented at 1:09 PM

    Added forgotten patch
  • Federico Brubacher
    Federico Brubacher commented at 11:32 AM

    I meant to say in the previous comment that the issue was present in master before my fix.
  • Federico Brubacher
    Federico Brubacher commented at 11:29 AM

    I've attached a patch.

    "I'm trying to say that attributes of clonned object should be threated as changed? only if they differ from defaults."

    I think I can agr...