Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Simon Jefford's latest activity

Saturday, September 11 2010
5215 Configurable tld_length for subdomains was updated in Ruby on Rails
  • Simon Jefford
    Simon Jefford commented at 11:32 AM

    This has now been applied by wycats via a pull request to rails/rails and can now be closed.

Thursday, August 12 2010
5215 Configurable tld_length for subdomains was updated in Ruby on Rails
Wednesday, July 28 2010
5215 Configurable tld_length for subdomains was updated in Ruby on Rails
Tuesday, July 27 2010
5215 Configurable tld_length for subdomains was updated in Ruby on Rails
  • Simon Jefford
    Simon Jefford commented at 4:00 PM

    Figured out where the initializer tests are. I've attached a new patch.

  • Simon Jefford
    Simon Jefford created the ticket at 3:43 PM

    I just watched the RailsCast on subdomains and it struck me that calling request.subdomain(tld_length) isn't very maintainable. Please find attached a patch tha...

Thursday, July 15 2010
5128 Rack-mount missing from Gemfile was created in Ruby on Rails
Wednesday, May 19 2010
3057 Reorganize app tests was updated in Ruby on Rails
  • Simon Jefford
    Simon Jefford commented at 4:30 PM

    Hmm, I see what you mean. The problem is it falls over when you're using the new structure (because Casey's patch removes the deprecated tests when the correspo...

  • Simon Jefford
    Simon Jefford commented at 3:19 PM

    I applied Casey's patch OK.

    There's one problem that I can see - "rake test" still tries to run the deprecated tasks. I've uploaded a version of the patch which...

4057 Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ha... was updated in Ruby on Rails
  • Simon Jefford
    Simon Jefford commented at 3:28 PM

    +1 Patch applies and tests run.

    I have, however, taken the liberty of removing whitespace errors - patch preserves authorship.

Sunday, May 16 2010
4602 Make 's' reserved word in 'rails ...' command was updated in Ruby on Rails
  • Simon Jefford
    Simon Jefford commented at 5:54 PM

    Done - here's the split patches.

    Thanks José