Activity (RSS)

I just realized that strings without specified time zones are interpreted as being in UTC. While one could theoretically just use Time.zone.parse, it defeats t...

I've been having trouble with time zones in my project. This helps. +1

The tests are now consistently passing for me no matter my system date / time zone / DST value. +1, this is a handy feature.

I noticed a problem with DST due to TimeZone not knowing which period it is in. This has been fixed in the new patch (as well as the tests using time zones fro...

Ignore my comment about eager loading being borked, I forgot I needed to do :select => 'id' as well. Issue still stands, however.

I'm bumping this again with a test

class AssociationsJoinModelTest < ActiveRecord::TestCase

  def test_my_little_test
    p = Post.find(:all, :select =>...

Good idea, but -

a) Why not just always clone the options?

b) It would be much more likely that this gets accepted if you supply in patch form (http://www.tp...

Hi,

this is my first patch, so... here's hoping that I'm posting this in the right place.

It is possible for a model to overwrite its to_xml method in a way ...

Thanks for applying that. I didn't read that bit about submitting a patch instead of forking until after I had already done it.

(from [123e55686de920499cc8572f3a8b4d585d20ab02]) Fix bug where plugin init.rb files from frozen gem specs weren't being run. (pjb3) [#122 state:resolved]

ht...

Hey, I just pushed this to my rails fork, but I didn't merge the commit right. Sorry about that.

Also it's not necessary to create a fork for minor patches l...

If you have an unpacked gem that has a rails/init.rb initialization file, it doesn't get called. This patch fixes that.

http://github.com/pjb3/rails/com...

Rick, Thanks for the patch,

I will look into it at the end of the day.

One thing about turning off the session and about protecting ajax-requests in general....

If you want to protect your Rails 2.0 app:

class ApplicationController < ActionController::Base
  def verifiable_request_format?
    request.content_type !=...

Ah, forgot about Mime::MULTIPART_FORM and Mime::URL_ENCODED_FORM. Wee.

Here's my commit with the change. It's in my personal fork until I've tested it in Lighthouse and deployed it. I'd appreciate if anyone else using CSRF prote...

(from [8ded457b1b31b157d6fe89b553749579e5ac4a27]) Added logic to associations.rb to make sure select_for_limited_ids

includes joins that are needed to reach t...

+1. tests all pass, looks sane (also see discussion on trac)

(from [2c39836dc3c06813fce031d1bb390149b53ebd1c]) Refactored and fixed Resources.map_member_actions to make use of custom ActionController::Base.resources_path...

The sqlite3 tests pass for me, are they failing for you?

Good catch! Hadn't thought of that one. I'll give it a whirl later today but looks good to me

Commmitted.. thanks.

Cool, rake db:structure:dump works. Merged into rails/master. Thanks everyone.

(from [37599d16f2374179ebf001aeb79ff121e3d67519]) regression test for bug introduced in [6a6b4392c16c665eb713705f2b38e959a658eeef] [Ian White] [#22 state:resol...

Too slow! I got it...

This assertion is designed to help people test their use of flash and flash.now - and will give sensible errors if they use the wrong one.

Flash.now in partic...

This is a patch from trac: http://dev.rubyonrails.org/ticke...

It allows for multiple columns to used in calculation groups.

The patch didn't work with the l...

The following patch defines a bunch of convenience assertions for general testing purposes. We've got assert_contains, assert_does_not_contain, assert_empty, ...

1. I agree

2. I agree, though I still think that if there is a all-in-one assertion helper for the "test more than needed, just in case" people there should b...