Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Activity (RSS)

Saturday, May 24 2008
add failing test case for block-setti... was committed by Repository at 7:35 AM
Added :select option to has_one and b... was committed by Repository at 6:58 AM
241 Added :select options to has_one and belongs_to was updated
  • Repository
    • State changed from new to resolved
    by Repository at 6:58 AM

    (from [8d0b4fa39fab6e5d1e3382b4b137cc47e559b0be]) Added :select option to has_one and belongs_to, remove unused :order option on belongs_to.

    Signed-off-by: Mi...

249 better coloration on error messages was updated
  • Roger
    Roger commented at 12:20 AM

    v4 combine all commits into a single commit, add better colors. This is a nice patch for being able to instantly see which line your code erred on.

Friday, May 23 2008
249 better coloration on error messages was updated
  • Roger
    Roger commented at 11:40 PM

    v3 takes out an extra line I had added in there by mistake

  • Roger
    Roger commented at 11:35 PM

    This version of the patch [v2] now adds coloration for the line on which the error occurred.

  • Roger
    Roger commented at 11:01 PM

    to test this patch apply, then add a syntax error to a view, and go to that view. It should have a red filename now [dark red].

  • Roger
    Roger created the ticket at 10:53 PM

    this patch makes it so that on rails' code based error messages, the filename is shown in red, so that people can identify more easily which file they need to ...

248 Not able to use block-setting of attributes via association was updated
  • Trevor Turk
    Trevor Turk commented at 11:24 PM

    Awesome - thanks, Ryan!

    I've tagged this ticket with the "patch" keyword, so hopefully it'll get picked up.

  • Ryan Bates
    Ryan Bates commented at 11:01 PM

    Here's a patch.

  • Trevor Turk
    Trevor Turk created the ticket at 9:59 PM

    Perhaps this could be viewed as a feature request, but it seemed like a bug to me. On Rails Edge, you can't set attributes with a block if you do so through an...

246 more verbose warning on boot failure was updated
  • Roger
    Roger commented at 11:00 PM

    here's the same patch using the approved git style patch instead of git diff.

    To test this patch apply, then go to boot.rb and add

    require 'nonexisting' with...

  • Roger
    Roger created the ticket at 6:45 PM

    It would be helpful for at least a few people [myself included] if, when rails encounters a LoadError loading rubygems, it outputs what the error was.

    In my i...

247 validates_associated - Detailed Validation error messages on associations was updated
  • Brian Takita
    Brian Takita commented at 10:47 PM

    I attached a patch.

  • Brian Takita
    Brian Takita created the ticket at 7:23 PM

    When an associated object (has_one, belongs_to, has_many, etc.) has a validation error, Rails currently gives a non-detailed error message. For example we have...

245 Add Reply-To to ActionMailer was created
  • Adam Traver
    Adam Traver created the ticket at 6:44 PM

    This patch adds Reply-To functionality to ActionMailer. TMail already supports this functionality through the reply_to method, but it wasn't exposed directly t...

244 Improvements to simplified_type for Oracle adapter was created
  • Nate Wiger
    Nate Wiger created the ticket at 6:29 PM

    This patch refines the types returned by simplified_type for the Oracle AR adapter. This is especially useful when coupled with plugins that do DB reflection,...

87 Dependencies shouldn't swallow errors from required files. was updated
  • Tom Ward
    Tom Ward commented at 6:10 PM

    That specific problem (the plugin-with-hyphenated-name) loading issue was fixed in #24. I got tripped up by that too.

  • Roger
    Roger commented at 6:01 PM

    I believe it happened to me if there was an error in a plugin loading. Like a syntax error in one of the files. The 'real' error message was never output.

    I...

  • Tom Ward
    Tom Ward commented at 3:54 PM

    I've only found one way to reproduce this; In production mode, if an error occurs on the first require of a file, on subsequent requires the error will mask th...

243 Routing should raise error if invalid http method used was created
  • Tom Ward
    Tom Ward created the ticket at 5:04 PM

    Using the following routes.rb:

    ActionController::Routing::Routes.draw do |map|
      map.resources :bugs, :member => {:this => :should_raise_an_error}
    end
    

    Wha...

242 Fixing form_authenticity_token in the test environment was updated
  • Pratik
    • Title changed from [PATCH] Fixing form_authenticity_token in the test environment to Fixing form_authenticity_token in the test environment
    by Pratik at 4:35 PM
  • Tiago Macedo
    Tiago Macedo created the ticket at 4:32 PM

    In trunk (and 2.0x) using form_authenticity_token in a template will result in an error because protect_from_forgery is disabled.

    In the rare ocasion of havin...

182 Routes restricted to HEAD fail to be matched was updated
  • Tom Ward
    Tom Ward commented at 3:05 PM

    Now that sounds like a valid bug which should certainly be fixed.

  • Chris Hapgood
    Chris Hapgood commented at 2:51 PM

    Tom,

    Thanks for taking the time to look at this ticket a second time. I accept that this request is not going to be implemented, and I can live with it.

    It ...

  • Tom Ward
    Tom Ward commented at 2:33 PM

    It's my understanding that a HEAD request to a URI should always return exactly the same headers as a GET request to the same URI. By restricting methods allo...

  • Chris Hapgood
    Chris Hapgood commented at 1:22 PM

    "It makes no sense to restrict a route to just HEAD requests."

    That's a bit dogmatic (or should I say "opinionated"?). I need a low- cost action/resource tha...

101 Custom rake task without desc not listed with rake --tasks was updated
  • Pratik
    • State changed from new to invalid
    by Pratik at 12:42 PM
241 Added :select options to has_one and belongs_to was created
  • José Valim
    José Valim created the ticket at 10:32 AM

    Now, since we preload associations, :select options will work great in has_one and in belongs_to, so I've added this option.

    But a bug is also fixed in this p...

240 A useful "methods" with my_methods was updated
  • Jan De Poorter
    Jan De Poorter commented at 9:53 AM

    I always use

    @object.class.instance_methods(false)

    Which gives me all public methods of the class without it's super-class methods

    jay

  • Ben Sandofsky
    Ben Sandofsky created the ticket at 9:00 AM

    When troubleshooting, it's useful to see a list of methods available on an object. Unfortunately, it comes along with a bunch of standard object methods like "...

230 Fire model callbacks before notifying observers was updated
  • Mark Van Holstyn
    Mark Van Holstyn commented at 8:00 AM

    +1

    I think it makes much more sense for model callbacks to fire first, then observers. Tests all look good and pass.

  • Brandon Keepers
    Brandon Keepers commented at 5:06 AM

    I can't think of any reason why it should be the way it is. Seems logical that the callbacks defined closest to the model should be called first.

    +1 - patch a...

144 Bug in Rails Route Globbing was updated
  • Michael Koziarski
    Michael Koziarski commented at 1:06 AM

    We'll live with the new behaviour. If you did :some_non_globbed_params => 'foo/bar' it'd do the same thing.

  • Michael Koziarski
    Michael Koziarski commented at 1:04 AM

    Adding a releasenotes tag so we remember to mention it.

Thursday, May 22 2008
Mention partial updates in environmen... was committed by Repository at 10:07 PM
Return Partial Updates to be purely o... was committed by Repository at 10:01 PM
Fix auto_link helper for already link... was committed by Repository at 9:12 PM
72 auto_link fails to recognize urls separated by space was updated
  • Repository
    • State changed from open to resolved
    by Repository at 9:12 PM

    (from [1a73e98660b29a2ce9eccd5b0776367a4969a012]) Fix auto_link helper for already linked urls. [#72 state:resolved]

    Signed-off-by: Pratik Naik

    http://githu...

  • Pratik
    Pratik commented at 9:12 PM

    Thanks for the patch Kevin.

  • Kevin Glowacz
    Kevin Glowacz commented at 8:32 PM

    here is a patch that fixes the original bug but doesn't break already linked urls

  • Pratik
    • State changed from resolved to open
    by Pratik at 7:43 PM
  • Kevin Glowacz
    Kevin Glowacz commented at 6:02 PM

    I have no idea why it just marked this as resolved with my last comment.

1 earlier change…
  • Kevin Glowacz
    • State changed from open to resolved
    by Kevin Glowacz at 5:59 PM

    Here is a failing test for what (what I think) Eugene was talking about:

    assert_equal '<a href="http://google.com">Google</a>', auto_link('<a href="http://goo...
239 Change :select precedence in construct_finder_sql to favor options[:select] was updated
  • Pratik
    • Title changed from [Patch] Change :select precedence in construct_finder_sql to favor options[:select] to Change :select precedence in construct_finder_sql to favor options[:select]
    by Pratik at 8:06 PM
  • Andrew White
    Andrew White created the ticket at 3:32 PM

    Currently construct_finder_sql gives precedence to the :select from the current scope over :select passed in the options parameter. Not only is this counterint...

227 complex versions in config.gem fails was updated
  • jeff
    jeff commented at 3:25 PM

    recreated patch using git

238 Namespace Inflector, Dependencies, OrderedOptions, and TimeZone under ActiveS... was updated
  • josh
    josh commented at 3:23 PM

    Waiting till after 2.1.

  • josh
    • State changed from new to open
    by josh at 3:23 PM
  • josh
    josh created the ticket at 3:23 PM

    Properly namespace Inflector, Dependencies, OrderedOptions, and TimeZone under ActiveSupport. Includes deprecation warnings for those using the old constants a...