#1030 Multiparameter Attributes incorrectly do time zone conversion on time-only columns - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#1030 ✓resolved

Multiparameter Attributes incorrectly do time zone conversion on time-only columns

Reported by Geoff Buesing | September 12th, 2008 @ 12:07 AM | in 2.1.2

Multiparameter Attributes are doing a time zone conversion for attributes assigned to a time-only column, resulting in the wrong time being sent to the database.

To fix this, we just need to do a check in ActiveRecord::Base#instantiate_time_object for the column type, and only do a time zone conversion for :datetime and :timestamp columns.

Comments and changes to this ticket

Michael Koziarski September 12th, 2008 @ 02:34 PM
- Milestone set to “2.1.2”
I agree this should also be fixed in 2-1-stable. So I've updated the milestone accordingly, just remember to fix it in both before closing the ticket ;)
Repository September 15th, 2008 @ 12:17 AM
- State changed from “new” to “resolved”
(from [d95943b276d52c5bc4f033e532376667badbad9f]) Multiparameter attributes skip time zone conversion for time-only columns [#1030 state:resolved] http://github.com/rails/rails/co...
Repository September 15th, 2008 @ 12:35 AM
(from [8bd62e31682b6fa3deb499c6a5338906fc559188]) Multiparameter attributes skip time zone conversion for time-only columns [#1030 state:resolved] http://github.com/rails/rails/co...