This project is archived and is in readonly mode.
Patch to enable --database=ibm_db
The --database option currently accepts the following values: mysql/oracle/postgresql/sqlite2/sqlite3/frontbase. Notice that the existing generators are not limited to the core adapters only.
The attached patch adds support for ibm_db, as well. Running:
rails my_app -d ibm_db will generate a
config/database.yml file that is tailored for the ibm_db
Comments and changes to this ticket
Looks nice. Some suggestions :
- Please use 'development', 'test', '_production' postfixes.
- Instead of commented values for schema, host, port, account etc. why not fill sensible defaults ? Not being an IBM DB user, I don't know what they might be.
- I'd skip those tests
Pratik, thank you for reviewing the patch.
I proceeded with reviewing the patch developed by the API development team, and changed a few things, also incorporating some of your suggestions.
A couple of important considerations are in order though:
The development, test and _production postfixes are not acceptable for DB2. This is due to the fact that database names are currently limited to 8 characters. This is why the resulting database names are derived from the application name (truncated to 4 characters) and contracted postfixes;
I changed the parameters for which default values exist, to their defaults. That said, some of the optional parameters are entirely arbitrary and have no defaults, as such I placed obvious placeholders. The password field is empty for the other adapters, so I left it blank as well.
I think the resulting config/database.yml file looks good, all things considered and it's ready to be introduced into the core.
Thank you, Antonio
- State changed from new to resolved
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Tickets have moved to Github
The new ticket tracker is available at https://github.com/rails/rails/issues