Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

auto_link helper fails to parse some URLs with colons

#1341

Looks like this issue was partially fixed 2 years ago (http://dev.rubyonrails.org/chang..., but it still fails on URLs like the following:

https://www.google.com/doku.php?...:resource:scs:start

The difference between the link above and the one provided in the test_helper_test.rb is that the colons occur after the query param (?). The current test only tests colons in URLs without query params:

http://en.wikipedia.org/wiki/Wik...

Reported by Rich · November 7th, 2008 @ 12:55 AM

State: committed
Milestone: 2.x
Assigned to: nobody
Importance: none

Activity

  1. Rich
    Rich

    heh... looks like the sample URL above got munged by lighthouse (possibly the same bug I'm reporting). Here's the example in a pastie:

    http://pastie.org/309204

    November 7th, 2008 @ 12:57 AM

  2. Rich
    Rich
    • Tag changed from auto_link, helper, text_helper, view, view_helper to auto_link, helper, patch, text_helper, view, view_helper

    Fixed in attached patch... very simple fix. Includes change to test.

    November 7th, 2008 @ 04:08 AM

  3. Repository
    Repository
    • State changed from new to committed

    (from [d3ec1d3c22904c8801945b56956466f8ead9f3c1]) auto_link view helper was failing on URLs with colons after a query param

    Signed-off-by: Michael Koziarski michael@koziarski.com [#1341 auto_link helper fails to parse some URLs with colons state:committed] http://github.com/rails/rails/co...

    November 7th, 2008 @ 07:34 PM