This project is archived and is in readonly mode.
auto_link helper fails to parse some URLs with colons
Reported by Rich | November 7th, 2008 @ 12:55 AM | in 2.x
Looks like this issue was partially fixed 2 years ago (http://dev.rubyonrails.org/chang..., but it still fails on URLs like the following:
https://www.google.com/doku.php?...:resource:scs:start
The difference between the link above and the one provided in the test_helper_test.rb is that the colons occur after the query param (?). The current test only tests colons in URLs without query params:
Comments and changes to this ticket
-
Rich November 7th, 2008 @ 12:57 AM
heh... looks like the sample URL above got munged by lighthouse (possibly the same bug I'm reporting). Here's the example in a pastie:
-
Rich November 7th, 2008 @ 04:08 AM
- Tag changed from “auto_link, helper, text_helper, view, view_helper” to “auto_link, helper, patch, text_helper, view, view_helper”
Fixed in attached patch... very simple fix. Includes change to test.
-
Repository November 7th, 2008 @ 07:34 PM
- State changed from “new” to “committed”
(from [d3ec1d3c22904c8801945b56956466f8ead9f3c1]) auto_link view helper was failing on URLs with colons after a query param
Signed-off-by: Michael Koziarski michael@koziarski.com [#1341 state:committed] http://github.com/rails/rails/co...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Repository
Rich
Attachments
Referenced by
-
1341
auto_link helper fails to parse some URLs with colons
Signed-off-by: Michael Koziarski michael@koziarski.com [#...