This project is archived and is in readonly mode.

#14 ✓resolved
Jonathan Weiss

Support options passed to ActiveSupport::Cache :mem_cache_store

Reported by Jonathan Weiss | April 16th, 2008 @ 09:43 PM

The inclusion of Memcache-Client to ActiveSupport::Cache made it easier to use but also removed the flexibility to supply custom options.

This patch(+unit tests) fixes this and allows you to supply extra options:

ActiveSupport::Cache.lookup_store :mem_cache_store, "localhost"

ActiveSupport::Cache.lookup_store :mem_cache_store, "localhost", '192.168.1.1', :namespace => 'foo'

or

config.action_controller.fragment_cache_store = :mem_cache_store, 'localhost', {:compression => true, :debug => true, :namespace =>'foo'}

See http://github.com/jweiss/rails/c...

Comments and changes to this ticket

  • josh

    josh April 17th, 2008 @ 01:21 AM

    • State changed from “new” to “open”
    • Assigned user set to “josh”
    • Title changed from “[PATCH] make the new ActiveSupport::Cache :mem_cache_store accept options” to “Support options passed to ActiveSupport::Cache :mem_cache_store”
  • Repository

    Repository April 17th, 2008 @ 06:59 PM

    • State changed from “open” to “resolved”

    (from [9e1d506a8cfedef2fdd605e4cbf4bf53651ad214]) Support options passed to ActiveSupport::Cache :mem_cache_store [#14 state:resolved]

    Signed-off-by: Joshua Peek

    http://github.com/rails/rails/co...

  • josh

    josh April 17th, 2008 @ 07:02 PM

    Nice work, I'd consider this ticket for the "ideal" patch. Has a nice write up, simple implementation, tests, a diff patch, and a github fork. Great work, please continue this format :)

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Tags

Referenced by

Pages