Rails Ruby on Rails → 2.x

Comments and changes to this ticket

• You flagged this item as spam.
  

  James Le Cuirot November 21st, 2008 @ 04:20 PM

  Here's a patch against 2.1 for anyone that needs it.

  • include_eager_group-2-1.patch 3.6 KB
• 

  Pratik March 8th, 2009 @ 12:11 AM

  • Assigned user set to “Frederick Cheung”

• You flagged this item as spam.
  

  Gabe da Silveira August 9th, 2009 @ 06:27 AM

  • Tag changed from “2.1, eager_loading, edge, group, include, join, patch” to “2.1, bugmash, eager_loading, edge, group, include, join, patch”

  Tagging this one bugmash since Pratik suggested it to me (he knows how much I love these eager loading issues).

• You flagged this item as spam.
  

  Gabe da Silveira August 9th, 2009 @ 07:29 AM

  • Tag changed from “2.1, bugmash, eager_loading, edge, group, include, join, patch” to “2.1, bugmash, eager_loading, edge, group, include, join, patch, verified”

  verified the test case against 2-3-stable. I rebased the patch, and it fixed the problem for mysql, but raised two different errors in sqlite and pgsql. This is a deeper problem, but I think the initial patch is correct, just need to identify the underlying issues. Here is my rebased version on 2-3 which passes for mysql but fails for sqlite and postgres. I'll pick this up later if no one else does.

  I've attached a patch.

  • partial-fix-for-2-3.diff 4.7 KB

• You flagged this item as spam.
  

  James Le Cuirot August 9th, 2009 @ 10:36 AM

  I realised shortly after posting this that I didn't actually need it and I could approach the problem in a better way. I've forgotten the details though. I doubt many people would need this to be fixed but it could be worth doing just for completeness.

• 

  Rizwan Reza January 20th, 2010 @ 11:02 AM

  • State changed from “new” to “invalid”
  • Tag changed from “2.1, bugmash, eager_loading, edge, group, include, join, patch, verified” to “2.1, eager_loading, edge, group, include, join, patch, verified”