Rails Ruby on Rails

Comments and changes to this ticket

• 

  Michael Koziarski December 17th, 2008 @ 01:46 PM

  • Milestone cleared.
  • Assigned user set to “Michael Koziarski”

• You flagged this item as spam.
  

  Christoph Petschnig February 26th, 2009 @ 11:00 AM

  This bug occurs also with a Proc object that returns a string.

  The gist-url with the patch was deleted, so I post an easy workaround for this bug. Simply set the content type yourself somewhere inside the macro, like:

  caches_action :index, :if => Proc.new { |c| result = c.cache_me?; c.headers["Content-Type"] = 'text/xml; charset=UTF-8' if result; result },

  :cache_path => Proc.new { |c| File.join('abc', c.some_method) }
  
  

• You flagged this item as spam.
  

  Mislav February 26th, 2009 @ 01:04 PM

  Aw damn, I've been cleaning up my gists and deleted the patch because I thought it was applied. If anyone needs it back, shout now. I was pretty sure this was fixed soon after this was reported.

  Christoph, can you make a failing test for your case?

• You flagged this item as spam.
  

  Christoph Petschnig February 28th, 2009 @ 12:25 AM

  Ok, I made the failing tests.

  I choose to attach a whole rails project instead of a single file. Please look at docs/README for some explanation.

  I am not an experienced tests writer, yet it seems to me, that I found two other bugs while writing the tests. Please look at the comments in test/functional/xml_caching_controller_test.rb therefore.

  I would like to investigate that a little further, but I will be buzy for the next seven days.

  • ticket_1585_bug_test.tar.gz 12.3 KB

• You flagged this item as spam.
  

  Mislav March 10th, 2009 @ 11:05 PM

  • Tag changed from “caches_action, format, patch” to “bug, caches_action, caching, format, patch”

  Here's the revised patch with failing tests for both cases: string key or proc that returns a string.

  • action-cache-keys.patch 4 KB
• 

  Repository March 11th, 2009 @ 12:07 AM

  • State changed from “new” to “resolved”

  (from [fa45540cdb30cee44983c9121e3ebfc317d21668]) Ensure correct content type is declared after cache hits on actions with string cache keys [#1585 state:resolved]

  Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...