Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Restore cookie session store httponly default to true

#1784

#1046 Http only cookies in CookieStore changed the cookie session store to default to httponly cookies. However, this default setting was lost when the cookie store was switched to a rack based session store. Both the Active Record session store and memcache session store currently default to httponly cookies.

This patch restores the default of httponly to true in the cookie session store and removes an extraneous .dup call on the options hash in initialize. Since #symbolize_keys is called on the options, which returns a new hash, the dup call isn't needed.

Reported by Cody Fauser · January 20th, 2009 @ 12:40 PM

State: resolved
Milestone: none
Assigned to: josh josh
Importance: none

Activity

  1. josh
    josh
    • Milestone cleared.
    • State changed from new to open
    • Assigned user set to josh

    January 20th, 2009 @ 04:20 PM

  2. Repository
    Repository
    • State changed from open to resolved

    (from [c090e5e0755bea3a7cd7135329f8dae6094810b6]) Restore cookie store httponly default to true. Remove extraneous dup of options on initialization [#1784 Restore cookie session store httponly default to true state:resolved] Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...

    January 20th, 2009 @ 06:40 PM