This project is archived and is in readonly mode.

#1813 ✓invalid
Reuben Sivan

time_zone.rb data corrections

Reported by Reuben Sivan | January 28th, 2009 @ 11:08 PM | in 2.x

Fixed incorrect mappings for: - Gerogetown - Buenos Aires

Comments and changes to this ticket

  • Geoff Buesing

    Geoff Buesing January 29th, 2009 @ 03:09 AM

    • State changed from “new” to “invalid”

    Re: Buenos Aires -- you're changing the mapping from "America/Argentina/Buenos_Aires" to "America/Buenos_Aires", but in the full TZInfo gem, "America/Buenos_Aires" is just a linked timezone pointing to "America/Argentina/Buenos_Aires", so nothing to be gained from making this change.

    Re: Georgetown -- the ActiveSupport Georgetown zone represents the Georgetown in Argentina, not the Georgetown in Puerto Rico.

  • Reuben Sivan

    Reuben Sivan January 29th, 2009 @ 04:45 PM

    There is no Gerogetown city in Argentina, and there is no San Juan time zone in Argentina (although there is a San Juan province and its capital city is also called San Juan). So the options are to either fully remove that entry, or try to figure out what the authors meant. I did a search for Georgetown, and there is only one major city name Georgetown in South America, the capital of Guyana, which has no named equivalent in the time zone database. Also in the reference below you will find that the time zones are names continent/city, not continent/country/city, so America/Argentina/Buenos_Aires is invalid, while America/Buenos_Aires is a valid entry. References: http://twiki.org/cgi-bin/xtra/tz.... I will re-submit as two separate changes in order to keep the discussion separate.

  • Geoff Buesing

    Geoff Buesing January 29th, 2009 @ 08:00 PM

    Re Georgetown -- see my comments on http://rails.lighthouseapp.com/p...

    Re America/Argentina/Buenos_Aires -- see the naming scheme of the TZInfo gem -- http://rubyforge.org/projects/tz... -- this is a valid name for how this gem retrieves zones (which is what the TimeZone::MAPPING values are used for.)

    As far as America/Argentina/Buenos_Aires being a legit Olson name, afaik three-level names are legit, they're just not as common as two-level names.

    From Wikipedia:

    "In a few rare cases the Location is itself represented as a compound name, for example the time zone “America/Indiana/Indianapolis”. The only three-level names currently include those under “America/Argentina/…”, “America/Kentucky/…”, “America/Indiana/…”, and “America/North_Dakota/…”."

    http://en.wikipedia.org/wiki/Zon...

  • klkk

    klkk May 23rd, 2011 @ 02:54 AM

    • Importance changed from “” to “”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Pages