Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Clearing dependencies in reload_application performance issue

#1898

As of this commit clearing dependencies has been moved to reload_application. If a plugin loads any constants in prepare_dispatch these are then cleared and reloaded unnecessarily. This is especially the case with the Thinking Sphinx plugin which loads all models in its prepare_dispatch callback

The attached patch moves the cleanup code before prepare_dispatch so that any constants from previous requests are cleared before application/plugin code might access them.

Reported by Andrew White · February 6th, 2009 @ 05:40 PM

State: resolved
Milestone: none
Assigned to: josh josh
Importance: none

Activity

  1. DHH
    DHH
    • Assigned user set to josh
    • Milestone cleared.

    February 7th, 2009 @ 01:26 PM

  2. josh
    josh
    • State changed from new to open

    February 7th, 2009 @ 05:09 PM

  3. Repository
    Repository
    • State changed from open to resolved

    (from [5f5d2d30a0c02d15b37f8f07db1b0abe9c7309f4]) Move cleanup before prepare_dispatch so that constants are not loaded twice [#1898 Clearing dependencies in reload_application performance issue state:resolved] Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...

    February 7th, 2009 @ 06:08 PM