This project is archived and is in readonly mode.

#2007 ✓invalid
pbuddy

assert_select in 2.3.0RC1 again

Reported by pbuddy | February 18th, 2009 @ 12:21 PM | in 2.x

Hi,

updating to Rails 2.3 RC1 broke some of my functional tests, which all ran without errors in 2.2.2. Namely, the line


assert_select 'div#flash'

is now supposed to be false, while changing it to


# assert_select 'div#flash'
assert_match '<div class="subcolumns note" id="flash">', @response.body

turns out to be true.

I tried to trace it and found that response_from_page_or_rjs in selector_assertions.rb returns an empty root:


#<HTML::Node:0x3e87274 @position=0, @children=[], @line=0, @parent=nil>

while in 2.2.2 it correctly returned my whole document body as content of root.

I can, of course, simply rewrite my tests, but I was wondering whether this is an expected behavior.

Alex

BTW: Yes, I've seen #1890 and I'm not using ActiveMerhcant. I've temporarily disabled some plugins and updated the rest. Unfortunately with no effect.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Pages