[AutosaveAssociation] should not validate associated model if marked_for_destruction

Good catch!

Oh, found another bug related to this topic. When Model marked_for_destruction? and has custom validation, then it's enters to the validation method, but it shouldn't:

  class ::Ship
    validate :validate_name

    private

    def validate_name
     if name && 'mustnt-go-here' == name
       errors.add(:name, :name_invalid)
       throw :mustnt_validate_when_marked_for_destruction
     end
    end
  end

  def test_should_skip_validation_and_destroy_the_associated_model
    @pirate.ship.update_attribute(:name, 'mustnt-go-here')
    @pirate.ship.mark_for_destruction

    assert_nothing_thrown do
      @pirate.update_attributes({ :ship_attributes => { :id => @ship.id,  :_delete => true } })
    end
  end

Thanks!

@Dmitry: Sorry that I missed your new comment. Next time please create a new ticket or change the state to open again.

About the problem; have you investigated already where the problem lies? And/or maybe a naive patch or something?

I have verified and applied this patch on my branch of 2-3-stable, which Micheal will look at and merge in before 2.3.4.

http://github.com/alloy/rails/commit/dbc56d67b644944dcff09afbcb2f7d...

Thanks!

[milestone:id#50064 bulk edit command]

(from [c52a50ec51f7466411c032d676590be67fd6a956]) Fix autosave association to skip validation if it is marked for destruction. [#2064 [AutosaveAssociation] should not validate associated model if marked_for_dest... state:resolved] Signed-off-by: Eloy Duran eloy.de.enige@gmail.com
http://github.com/rails/rails/commit/c52a50ec51f7466411c032d676590b...

Automatic cleanup of spam.