Rails Ruby on Rails

Comments and changes to this ticket

• You flagged this item as spam.
  

  Tys von Gaza February 26th, 2009 @ 07:12 PM

  The example can be simplified to a single belongs_to, has_many relationship:

  
  AnswerSet
    has_many :answers
  
  Answer
    belongs_to :answer_set
  

  Wrong query should look something like this: Answer.find(:all, :joins => { :answer_set => :answers }, :conditions => { :answer_set => { :answers => { :question_id => 1 } } })

  Generates: SELECT "answers".* FROM "answers" INNER JOIN "answer_sets" ON "answer_sets".id = "answers".answer_set_id INNER JOIN "answers" answers_answer_sets ON answers_answer_sets.answer_set_id = answer_sets.id WHERE ("answers"."question_id" = 1)

  Should generate: SELECT "answers".* FROM "answers" INNER JOIN "answer_sets" ON "answer_sets".id = "answers".answer_set_id INNER JOIN "answers" answers_answer_sets ON answers_answer_sets.answer_set_id = answer_sets.id WHERE ("answers_answer_sets"."question_id" = 1)

• You flagged this item as spam.
  

  Tys von Gaza February 26th, 2009 @ 07:56 PM

  After thinking about this further, the root of the problem is how the conditions are built and doesn't have much to do with the joins.

  The following should really error out with bad sql, but it doesn't:

  Answer.find(:all, :conditions => { :answer_set => { :answers => { :question_id => 1 } } })

• You flagged this item as spam.
  

  Tys von Gaza February 26th, 2009 @ 09:08 PM

  • Tag changed from “2.3-rc1, active_record, conditions, joins” to “2.3-rc1, active_record, conditions, joins, tests”

  Here is a patch that adds the tests, not really sure where to begin to fix the bug through.

  • nested_conditions_bug.diff 1.6 KB
• 

  CancelProfileIsBroken August 5th, 2009 @ 02:12 PM

  • Tag changed from “2.3-rc1, active_record, conditions, joins, tests” to “2.3-rc1, active_record, bugmash, conditions, joins, tests”

• You flagged this item as spam.
  

  Gabe da Silveira August 8th, 2009 @ 09:41 PM

  verified that patch applies and tests fail on 2-3-stable

• You flagged this item as spam.
  

  Gabe da Silveira August 9th, 2009 @ 12:25 AM

  -1 on fixing this issue. After looking closely at this I don't think a fix is worth the overhead. In order to reliably fix this the conditions would need to know about joins and how the joined tables are named. That is add_joins! would need to probably pass the JoinDependency back to add_conditions! in AR::Base (or else duplicate the naming scheme which seems to be asking for trouble). Such a change would be a major refactoring that I think needs to be considered more holistically, and not considered before Rails 3 in any case. In order to merit the additional complexity this would need to solve a whole class of problems, or else inspire a refactoring that made the :conditions/:joins code more expressive.

  The workaround for this particular test case is simply to use:

  :conditions => { :'posts_authors.title' => "Welcome to the weblog" }
  

  instead of:

  :conditions => { :author => { :posts => { :title => "Welcome to the weblog" } } }
  

• You flagged this item as spam.
  

  Steve St. Martin August 9th, 2009 @ 12:33 AM

  verified

  -1 I agree with Gabe on this one, the re-factoring it would take for this could cause more issues then it solves.

  At the point the developer is adding :join and :conditions they are already making an informed choice based off of their knowledge of the database schema, i do not feel manually specifying table names is that much added work
  (ideally these types of things should be pulled into the model anyway where it's more proper for it to 'know' about its relationships / naming conventions)

• 

  Michael Koziarski August 9th, 2009 @ 01:25 AM

  • State changed from “new” to “wontfix”

  agree with the earlier commenters.

  The Arel merge may make fixing this easier.

• 

  CancelProfileIsBroken August 9th, 2009 @ 02:50 AM

  • Tag changed from “2.3-rc1, active_record, bugmash, conditions, joins, tests” to “2.3-rc1, active_record, conditions, joins, tests”
• 

  CancelProfileIsBroken August 9th, 2009 @ 11:19 AM

  • Tag changed from “2.3-rc1, active_record, conditions, joins, tests” to “2.3-rc1, active_record, conditions, joins, tests”
  • Milestone cleared.