This project is archived and is in readonly mode.
Seems like there is a bug in bolded block, or i don't understend logic of it's creators.
Reported by Freiwillen | March 19th, 2009 @ 01:26 PM | in 3.x
# File vendor/rails/actionpack/lib/action_view/helpers/url_helper.rb, line 518
518: def current_page?(options)
519: url_string = CGI.escapeHTML(url_for(options))
520: request = @controller.request
521: # We ignore any extra parameters in the request_uri if the
522: # submitted url doesn't have any either. This lets the function
523: # work with things like ?order=asc
524: **if url_string.index("?") **
525: **request_uri = request.request_uri**
526: **else **
527: **request_uri = request.request_uri.split('?').first**
528: **end**
529: if url_string =~ /^\w+:\/\//
530: url_string == "#{request.protocol}#{request.host_with_port}#{request_uri}"
531: else
532: url_string == request_uri
533: end
534: end
Comments and changes to this ticket
-
Joe Yates April 14th, 2010 @ 04:55 PM
The call to
split(line 527) was replaced in this commit: http://github.com/rails/rails/commit/5e0a05b8cb236d285ebb45de006dd3...
The code now seems correct. -
-
Santiago Pastorino February 2nd, 2011 @ 04:53 PM
- State changed from “new” to “open”
- Importance changed from “” to “”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino February 2nd, 2011 @ 04:53 PM
- State changed from “open” to “stale”
-
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
- Nobody is watching this ticket.