This project is archived and is in readonly mode.
[PATCH] 410 Gone as ResourceGone for ActiveResource
Our app needs to distinguish between unknown entities & removed entities. It would be nice if ActiveResource had a ResourceGone error class so that we could do this:
rescue ActiveResource::ResourceGone => e
..
end
instead of:
rescue ActiveResource::ClientError => e
if e.response.code.to_i == 410
...
else
raise
end
end
Attached is a patch to do this.
-
active-resource-410-gone.diff
3.98 KB
-
Jordan Brough- Assigned user cleared.
-
CancelProfileIsBroken- Tag changed from activeresource, patch to activeresource, bugmash, patch
-
Jatinder Singh
+1 it works cleanly on 2.3-stable. Changes to exists? should indeed take ResourceGone exception into account.
I added a missing test, but can't create a patch, until https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets... gets out of the door.
-
Jatinder Singh
I've attached a patch for a missing test to the patch by Jordan.
-
Kieran P- Title changed from 410 Gone as ResourceGone for ActiveResource to [PATCH] 410 Gone as ResourceGone for ActiveResource
-
Rizwan Rezaverified
+1 The patch by Jatinder applies to 2-3-stable only. All tests pass.
-
Elad Meidar+1 Verified, applies and tests pass on 2-3-stable.
Attached patch and tests for master (my name appears on the commit, i didn't know how to credit the original author, sorry).
-
Repository
- State changed from new to resolved
(from [916b18adeb0a1ae09fdaff21dda8d0bc8ed4ffa9]) Active Resource recognizes 410 as Resource Gone now [#2316 [PATCH] 410 Gone as ResourceGone for ActiveResource state:resolved] [Jordan Brough, Jatinder Singh]
Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/916b18adeb0a1ae09fdaff21dda8d0... -
Jeremy Kemper- Tag changed from activeresource, bugmash, patch to activeresource, patch
Worth backporting to 2-3-stable?
-
Repository
(from [be017fd7d54c9203dc574d8e1a6f22d80df0e899]) Active Resource recognizes 410 as Resource Gone now [#2316 [PATCH] 410 Gone as ResourceGone for ActiveResource state:resolved] [Jordan Brough, Jatinder Singh]
Signed-off-by: Pratik Naik pratiknaik@gmail.com
Conflicts:
activeresource/lib/active_resource/exceptions.rbSigned-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/be017fd7d54c9203dc574d8e1a6f22...