Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

double destroy should only decrement counters once

#2320
  1. call destroy on an object with a belongs_to association with counter_cache turned on
  2. call destroy a second time on same object

Expected behavior: counter_cache is decremented once since a total of one object was removed Actual behavior: counter_cache is decremented twice

Proposed patch solves this but in a non-ideal way since it adds a call to AR::B#exists? prior to every destroy. Presently when AR::B#destroy is called it freezes the object. We could check AR::B#frozen? instead, but this would also catch cases of frozen objects which have not yet been deleted.

The ideal solution would be an AR::B#destroyed? methods which could tell us if AR::B#destroy had been successfully called on the object.

Reported by Ben Tucker · March 24th, 2009 @ 12:39 AM

State: stale
Milestone: 3.x
Assigned to: nobody
Importance: none

Activity

  1. Ben Tucker
    Ben Tucker

    March 24th, 2009 @ 08:45 PM

  2. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.x to 3.x

    May 4th, 2010 @ 06:48 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Importance changed from to

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:40 PM

  4. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:40 PM