Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

TestRequest initializes session_options without defaults

#2403

After patch #2303 TestRequest doesnt initialize session_options was fixed session_options were initialized but session_options[:id] would return nil.

request.session_options should be initialized with the correct default values

Reported by yairgo · April 2nd, 2009 @ 11:37 PM

State: resolved
Milestone: 2.x
Assigned to: josh josh
Importance: none

Activity

  1. yairgo
    yairgo
    • Tag changed from 2.3.2, request.session_options, test_process to 2.3.2, patch, request.session_options, test_process

    April 2nd, 2009 @ 11:38 PM

  2. yairgo
  3. gaffo
    gaffo

    +1, been getting very annoyed of the deprecation warnings that I can't fix.

    April 3rd, 2009 @ 01:00 AM

  4. Ryan Angilly
    Ryan Angilly

    story checks out.

    I had monkey patched this in my test_helper and forgotten all about it!

    +1

    April 3rd, 2009 @ 01:40 AM

  5. Amos King
  6. Kyle Cross
    Kyle Cross

    I think this is much needed fix +1

    April 3rd, 2009 @ 02:30 PM

  7. Michael Koziarski
    Michael Koziarski
    • Assigned user set to josh

    April 5th, 2009 @ 10:10 AM

  8. josh
    josh
    • State changed from new to open

    April 7th, 2009 @ 03:14 PM

  9. Repository
    Repository
    • State changed from open to resolved

    (from [f448c70b3f6c6698bce9c95fa4328c251fe085ee]) added tests for session options being defaulted correctly to rack defaults [#2403 TestRequest initializes session_options without defaults state:resolved]

    Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...

    April 7th, 2009 @ 03:19 PM

  10. gaffo
    gaffo

    Josh, can you pull this into the latest 2.3 stable as well, such as 2.3.2.1?

    April 7th, 2009 @ 03:29 PM

  11. Repository
    Repository

    (from [ace154d067f619aca8a56988efdf9477898242ae]) added tests for session options being defaulted correctly to rack defaults [#2403 TestRequest initializes session_options without defaults state:resolved]

    Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...

    April 7th, 2009 @ 05:08 PM

  12. josh