This project is archived and is in readonly mode.

habtm assosiation, collection_singular_ids=ids method does not work if ids are not unique

#2491

example, if I set order.product_ids=[1,1,1,1] order.product_ids will return [1]

In associations.rb collection_singular_ids=ids method is defined as:


 define_method("#{reflection.name.to_s.singularize}_ids=") do |new_value|
              ids = (new_value || []).reject { |nid| nid.blank? }
              send("#{reflection.name}=", reflection.class_name.constantize.find(ids))
            end

Inside find method is used to get the records which is eliminating the duplicate ids.

Reported by osman.alpay (at gmail) · April 14th, 2009 @ 08:28 PM

Activity

Anuj Dutta
Did you ever fix this?

October 21st, 2009 @ 07:05 PM
laserlemon
+1

This behavior was certainly unexpected. I'll put together a patch.

November 20th, 2009 @ 09:13 PM

laserlemon

Scratch that. Looks like it's already fixed up in edge!

define_method("#{reflection.name.to_s.singularize}_ids=") do |new_value|
  ids = (new_value || []).reject { |nid| nid.blank? }.map(&:to_i)
  send("#{reflection.name}=", reflection.klass.find(ids).index_by(&:id).values_at(*ids))
end

Now it's just a waiting game.

November 20th, 2009 @ 09:55 PM

Jeremy Kemper
- Milestone changed from 2.x to 3.x
[bulk edit]

May 4th, 2010 @ 06:48 PM
Santiago Pastorino
- State changed from new to open
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

February 2nd, 2011 @ 05:03 PM
Santiago Pastorino
- State changed from open to stale
February 2nd, 2011 @ 05:03 PM