Rails Ruby on Rails → 2.x

Comments and changes to this ticket

• 

  CancelProfileIsBroken August 6th, 2009 @ 01:46 PM

  • Tag changed from “active_record, batches, enhancement, patch” to “active_record, batches, bugmash, enhancement, patch”

• You flagged this item as spam.
  

  Elise Huard August 7th, 2009 @ 09:55 PM

  i see the point of the order thing, but not of the limit - there is already a batch size ?

  tested with mysql - the tests run, but i would add test with :order => :asc too. I know that's the default too, but someone's bound to specify it if the option exists (in the foolproof category).

  tested the (only slightly) modified patch with
  mysql
  postgresql
  sqlite3

  with ruby1.8.6

  for ruby1.9.1:
  activerecord/lib/active_record/attribute_methods/read.rb:15:in undef_method': undefined methodid' for class ActiveRecord::Base' (NameError)<br/> probably due to something else, and it occurs with all above dbs.

  • find_in_batches_sorting.diff 10.8 KB
• 

  Michael Koziarski August 8th, 2009 @ 03:22 AM

  • State changed from “new” to “wontfix”

  This function is deliberately limited to primary_key order because those values don't change. If you order by title and manipulate the title in your block, you'll get nonsense / repeated options back.

  It's only intended for iterating over the whole collection in primary_key order.

• 

  Michael Koziarski August 8th, 2009 @ 03:22 AM

  • Tag changed from “active_record, batches, bugmash, enhancement, patch” to “active_record, batches, enhancement, patch”