This project is archived and is in readonly mode.

#2575 ✓stale
Peter Marklund

Not Eager Loading Application Classes Causes STI Breakage

Reported by Peter Marklund | April 28th, 2009 @ 02:25 PM | in 3.x

It turns out that the fact that we don't typically eager load application classes in the development environment (since cache_classes is false) can break STI since the subclasses may not have been loaded when the SQL query is constructed. See this blog post for more:

http://developer.newsdesk.se/200...

The only simple solution that comes to my mind right now is to always eager load application classes.

Comments and changes to this ticket

  • Frederick Cheung

    Frederick Cheung May 7th, 2009 @ 11:08 PM

    or explicitly load them at the end of the parent class' file (I know, not very nice)

  • dlibanori

    dlibanori August 12th, 2009 @ 11:04 PM

    I've added 2 configuration options:

    • reset_subclasses: clear AR::Base subclasses;
    • load_application_classes: eager load application classes;

    With those, you can set your development environment to eager load application and don't clear models subclasses. So it will load all models at startup time and subclasses structure will not be cleared after each request.

    If you change model' subclasses structure you have reboot application.

  • dlibanori

    dlibanori August 12th, 2009 @ 11:07 PM

    Last diff is to master, not Rails 2.3.3

  • Jeremy Kemper

    Jeremy Kemper May 4th, 2010 @ 06:48 PM

    • Milestone changed from 2.x to 3.x
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 05:02 PM

    • State changed from “new” to “open”
    • Importance changed from “” to “”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 05:02 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Attachments

Pages