Rails Ruby on Rails → 3.x

Comments and changes to this ticket

• You flagged this item as spam.
  

  Nathaniel Bibler May 27th, 2009 @ 03:24 PM

  • Title changed from “[Patch] Rails rake ignoring bundled frozen gem tasks” to “[PATCH] Rails rake ignoring bundled frozen gem tasks”

  Added custom Rake task loading test to Railties specifically for this patch. Patch file updated.

  • 0001-Added-frozen-gem-path-s-to-rakefile-loading-scheme-with-tests.patch 2 KB

• You flagged this item as spam.
  

  Nathaniel Bibler May 27th, 2009 @ 03:33 PM

  Tests were added at the request of Manfred Stienstra (manfred-s) in #rails-contrib.

  A custom task_test.rb file was added since the tests require loading rake and friends. I didn't want to dirty any of the existing non-rake-specific test files in railties.

  At some point, the task_test.rb should probably be extended to ensure that both vendor/plugins/**/tasks/**/*.rake and lib/tasks/*.rake are being properly loaded. But that didn't seem appropriate for this specific patch.

• 

  Matt Jones May 31st, 2009 @ 03:26 AM

  This is still under discussion on ticket #59 - the issue is more complicated than just a line of code. For instance, your patch means that gems in vendor/gems behave differently than gems in the system repository.

• You flagged this item as spam.
  

  Nathaniel Bibler May 31st, 2009 @ 03:38 AM

  Hey Matt. You are correct, Tyler Hunt and I were talking about that a few days ago when I had him read through it.

  I actually created something that could work for installed - but not frozen - gems. However, it required loading the Rails environment for every Rake task, which certainly isn't a good thing to do (it uses Rails.configuration to pull the dependent gems and then reading the gem specs for the locally-installed directory and scanning for a tasks subdirectory).

  Honestly, I don't see it as a down side to only support frozen gems. Doing so does not take away current functionality, but rather enhances it. Certainly it's not a 100% solution, but on a effort-to-reward ratio, I think it significantly outweighs any solutions I could come up with for supporting it all.

• 

  Matt Jones May 31st, 2009 @ 03:53 AM

  As previously noted, the issue is that this behavior is new. Gems that don't expect to have their rake tasks dropped into the app's namespace may have picked names for their tasks that break other things ('test', for instance...)

  The near-term workaround is probably to do a require on the tasks from the gem - check out Ryan Bates's comment on #59 for more detail.

• 

  Jeremy Kemper May 4th, 2010 @ 06:48 PM

  • Milestone changed from “2.x” to “3.x”

  [bulk edit]

• 

  Rohit Arondekar October 9th, 2010 @ 04:14 AM

  • State changed from “new” to “invalid”
  • Importance changed from “” to “”