#2747 Aggregation writer doesn't behave nicely when converter returns nil - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2747 ✓stale

Aggregation writer doesn't behave nicely when converter returns nil

Reported by Chris Hapgood | June 2nd, 2009 @ 09:43 PM | in 2.3.10

If the aggregation converter returns nil, the writer attempts to invoke the mapping method(s) anyway. Many such cases go undetected because nil responds adequately to common mapping methods such as :to_s, :to_i, etc.

(this behavior may even have been desirable before the :allow_nil option was introduced)

However, with mapping methods that are specific to the value class, returning nil from the converter results in NoMethod exceptions.

The attached patch ensures that normal nil mapping (all DB columns set to nil) occurs if the converter returns nil.

The patch includes failing tests and currently applies to edge and 2-3-stable.

No documentation changes are required. However, this patch further refines support for nil values such that the purpose of the :allow_nil => false option is unclear. It seems almost like a misplaced validation at this point.

Comments and changes to this ticket

Chris Hapgood June 2nd, 2009 @ 09:50 PM
- no changes were found...
- fix_aggregation_nil_conversion.diff 4.1 KB
Michael Koziarski June 10th, 2009 @ 04:22 AM
- Milestone changed from “2.x” to “2.3.4”
Jeremy Kemper September 11th, 2009 @ 11:04 PM
- Milestone changed from “2.3.4” to “2.3.6”
[milestone:id#50064 bulk edit command]
Rizwan Reza May 16th, 2010 @ 02:41 AM
- Tag changed from “activerecord, aggregations, patch, testcase” to “activerecord, aggregations, bugmash, patch, testcase”
[bulk edit]
Jeremy Kemper May 23rd, 2010 @ 05:54 PM
- Milestone changed from “2.3.6” to “2.3.7”
[bulk edit]
Jeremy Kemper May 24th, 2010 @ 09:40 AM
- Milestone changed from “2.3.7” to “2.3.8”
[bulk edit]
Jeremy Kemper May 25th, 2010 @ 11:45 PM
- Milestone changed from “2.3.8” to “2.3.9”
[bulk edit]
Jeremy Kemper August 30th, 2010 @ 02:28 AM
- Milestone changed from “2.3.9” to “2.3.10”
- Importance changed from “” to “”
[bulk edit]
Santiago Pastorino February 2nd, 2011 @ 04:33 PM
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
Santiago Pastorino February 2nd, 2011 @ 04:33 PM
- State changed from “open” to “stale”
You flagged this item as spam.
jfelchner May 17th, 2011 @ 02:28 AM
This is most definitely something that I would like to see fixed in 3.1. I am currently having the same problem where the converter should (correctly) return nil but the mapping methods are being called on it.

I understand resources are limited but 2 years seems like an excessively long amount of time to get a small change like this merged in.

If this particular patch is now out of date for the 3.x branch, let me know and I'll convert it over.
You flagged this item as spam.
Chris Hapgood May 17th, 2011 @ 02:02 PM
jfelchner,
At a minimum, this ticket is going to need to be moved to the new system on GitHub. Care to take a stab?
You flagged this item as spam.
jfelchner May 18th, 2011 @ 03:10 PM
I'm on it. Forgot you guys switched over. I also took a look and the patch is no longer valid. I'll submit a new pull request with a link back to this page.

Thanks for the quick reply Chris.