This project is archived and is in readonly mode.
Typo in Rails Plugin Manager is stopping git repos behind SSH working
Reported by Tekin | May 29th, 2008 @ 06:50 PM
I was having problems installing git based plugins over SSH, e.g.
ssh://[user@]host.xz/path/to/repo.git/
Bit of digging and I spotted a typo in railties/lib/commands/plugin.rb on line 166. @url should be @uri!
Tekin
Comments and changes to this ticket
-
Cheah Chu Yeow May 29th, 2008 @ 07:12 PM
There're no existing tests for this but this is an obvious fix. Good catch :)
-
Tekin May 29th, 2008 @ 07:38 PM
You would have thought so. It still took me a good half am hour of staring at that line before I spotted the typo in disguise!!
-
Pratik May 29th, 2008 @ 08:28 PM
- State changed from “new” to “resolved”
Fixed in http://github.com/rails/rails/co...
-
Tekin May 29th, 2008 @ 10:36 PM
I've just created another ticket:http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/278-patch-for-plugin-install-to-support-scp-syntax-git-repo-urls with a small patch, this time to add support for scp syntax urls, ala private repos on github.
The lack of tests here is problematic as there are lots of opportunities to improve this code. I'm going to find the time to do something about this at some point in the next few weeks..
-
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Cheah Chu Yeow
Pratik
Tekin