This project is archived and is in readonly mode.
HasOneAssociation should inherits from AssociationProxy not BelongsToAssociation.
Reported by Emilio Tagua | June 12th, 2009 @ 09:36 PM | in 2.x
HasOneAssociation is a subclass of BelongsToAssociation right now, i think it should be changed to be a subclass of AssociationProxy instead, since HasOneAssociation reimplements all methods and conceptually is not right.
All tests passes.
Comments and changes to this ticket
-
Emilio Tagua June 12th, 2009 @ 09:37 PM
- no changes were found...
-
Repository June 12th, 2009 @ 09:54 PM
- State changed from new to committed
(from [8db190acbae5d2a6f25d42d4137793a720a1689c]) HasOneAssociation inherits AssociationProxy since it shares nothing with BelongsToAssociation.
[#2796 state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/8db190acbae5d2a6f25d42d4137793...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Referenced by
- 2796 HasOneAssociation should inherits from AssociationProxy not BelongsToAssociation. [#2796 state:committed]