This project is archived and is in readonly mode.
generic reopening of core class should happen in AS/core_ext
Reported by Xavier Noria | June 13th, 2009 @ 09:42 AM | in 2.x
In Action Pack routing_ext.rb defines to_param for some core classes like TrueClass and NilClass, and adds a few general-purpose methods to Regexp. It evens defines Object#to_param again!
This patch performs a mini refactor to move that into standard places under AS/core_ext.
Comments and changes to this ticket
-
Xavier Noria June 13th, 2009 @ 11:49 AM
- no changes were found...
-
Xavier Noria June 13th, 2009 @ 11:49 AM
I just noticed originally those methods had no test coverage, I've added it in this second patch.
-
Repository June 13th, 2009 @ 11:02 PM
- State changed from “new” to “committed”
(from [b56169c26240db1b1cff3c6f65a34b7516a9fc15]) moves reopening of core classes to add generic stuff from Action Pack to AS/core_ext and adds tests
[#2798 state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/b56169c26240db1b1cff3c6f65a34b...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Xavier Noria
Attachments
Referenced by
-
2798
generic reopening of core class should happen in AS/core_ext
[#2798 state:committed]