Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

generic reopening of core class should happen in AS/core_ext

#2798

In Action Pack routing_ext.rb defines to_param for some core classes like TrueClass and NilClass, and adds a few general-purpose methods to Regexp. It evens defines Object#to_param again!

This patch performs a mini refactor to move that into standard places under AS/core_ext.

Reported by Xavier Noria · June 13th, 2009 @ 09:42 AM

State: committed
Milestone: 2.x
Assigned to: nobody
Importance: none

Activity

  1. Xavier Noria
    Xavier Noria

    June 13th, 2009 @ 11:49 AM

  2. Xavier Noria
    Xavier Noria

    I just noticed originally those methods had no test coverage, I've added it in this second patch.

    June 13th, 2009 @ 11:49 AM

  3. Repository
    Repository
    • State changed from new to committed

    (from [b56169c26240db1b1cff3c6f65a34b7516a9fc15]) moves reopening of core classes to add generic stuff from Action Pack to AS/core_ext and adds tests

    [#2798 generic reopening of core class should happen in AS/core_ext state:committed]

    Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
    http://github.com/rails/rails/commit/b56169c26240db1b1cff3c6f65a34b...

    June 13th, 2009 @ 11:02 PM