This project is archived and is in readonly mode.

Partial collection counter variable improperly named using :as

#2804

This is my first bug submission, so please forgive any deviations from protocol.

It seems that the :as option doesn't affect the counter variable name when rendering a collection. Here is an example.

From a brand new 2.3.2 app...

# [ApplicationController#index]

<% @cheesecakes = %w(strawberry chocolate graham-cracker) %>
<%= render :partial => "item", :collection => @cheesecakes, :as => :cheesecake %>

# [application/_item.html.erb]

<%= "#{item_counter+1} #{cheesecake}" %>
</br>

[OUTPUT]

1 strawberry 
2 chocolate 
3 graham-cracker

Should this "item_counter" not be "cheesecake_counter"? Instead "cheesecake_counter" does not exist.

undefined local variable or method `cheesecake_counter'

Reported by graham (at votary) · June 16th, 2009 @ 01:13 AM

Activity

Jeremy Kemper
- Milestone changed from 2.x to 3.x
[bulk edit]

May 4th, 2010 @ 06:48 PM
Dan Pickett
- Tag changed from 2-3-stable, partial, partial_counter, render to 2-3-stable, bugmash, partial, partial_counter, render
May 9th, 2010 @ 07:12 PM
Jeff Kreeftmeijer
- Tag changed from 2-3-stable, bugmash, partial, partial_counter, render to 2-3-stable, bugmash, master, partial, partial_counter, render, verified
Verified on master and 2-3-stable using the code snippet Graham provided.

May 15th, 2010 @ 10:49 AM
Jeff Kreeftmeijer
I've attached a patch that allows you to use cheesecake_counter in addition to item_counter in the above example for master. I'm working on a patch for 2-3-stable as we speak.

May 15th, 2010 @ 12:36 PM
Jeff Kreeftmeijer
And here's the patch for 2-3-stable. :)

May 15th, 2010 @ 01:12 PM
Jeff Kreeftmeijer
Sorry, was using wrong ticket numbers in my commit messages so I removed the patches. Here they are again.

May 15th, 2010 @ 01:19 PM
Jeff Kreeftmeijer
- partial_counter_with_as_master.diff 2.57 KB
- partial_counter_with_as_stable.diff 2.74 KB
May 15th, 2010 @ 01:21 PM
Anil Wadghule
+1 for this patch. I verified it against Rails master. It definitely helps in improving readability of code.

May 15th, 2010 @ 01:41 PM
Rizwan Reza
- Tag changed from 2-3-stable, bugmash, master, partial, partial_counter, render, verified to 2-3-stable, bugmash, bugmash-review, master, partial, partial_counter, render, verified
- State changed from new to verified
May 15th, 2010 @ 05:03 PM
Jeremy Kemper
- Milestone changed from 3.x to 2.3.6
May 15th, 2010 @ 06:32 PM
Repository
- State changed from verified to resolved
(from [fa99de0bd054576336c940ca78f3d1b35b6e490e]) partial counters with :as [#2804 Partial collection counter variable improperly named using :as state:resolved]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/fa99de0bd054576336c940ca78f3d1...

May 15th, 2010 @ 06:33 PM
Repository

(from [2de364636c06487faf48cbf9198bccd90a02eaf8]) partial counters with :as [#2804 Partial collection counter variable improperly named using :as state:resolved]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/2de364636c06487faf48cbf9198bcc...

May 15th, 2010 @ 06:33 PM
Rizwan Reza
- Tag changed from 2-3-stable, bugmash, bugmash-review, master, partial, partial_counter, render, verified to 2-3-stable, master, partial, partial_counter, render, verified
May 15th, 2010 @ 06:35 PM
Jeremy Kemper
- State changed from resolved to incomplete
Fix failing tests.

May 15th, 2010 @ 06:44 PM
Jeff Kreeftmeijer
Needed to check if as is set before trying to create a counter for it. I’ve attached a patch. :)
- as_counter_stable.diff 1.13 KB
May 15th, 2010 @ 07:11 PM
Repository
- State changed from incomplete to resolved
(from [5d7ad7ba41c1c4298ad6467d63ee20e6c6acdbfd]) make sure as is set before trying to build an #{as}_counter. [#2804 Partial collection counter variable improperly named using :as state:resolved]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/5d7ad7ba41c1c4298ad6467d63ee20...

May 15th, 2010 @ 07:22 PM
Repository

(from [da90fe94662b338a2430e99ff0d3298059a28a51]) make sure as is set before trying to build an #{as}_counter. [#2804 Partial collection counter variable improperly named using :as state:resolved]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/da90fe94662b338a2430e99ff0d329...

May 15th, 2010 @ 07:22 PM