This project is archived and is in readonly mode.
[PATCH] Rails 2.3.2 changes ActionController "expires_in" API needlessly
Reported by scott persinger | July 22nd, 2009 @ 08:11 PM | in 3.x
Pre-2.3.2 ActionController::Base.expires_in example:
expires_in 10.minutes, :private => false
Rails 2.3.2 version:
expires_in 10.minutes, :public => true
":private" option is ignored. This breaks cache headers for upgraded apps. There is no deprecation warning either.
You can read all about my outrage over here: http://geekblog.vodpod.com/?p=224
Comments and changes to this ticket
-
Susan Potter July 23rd, 2009 @ 02:02 AM
I committed a patch and test for the case here on my GitHub fork mbbx6spp/rails with commits:
* 316df387 Patch for #2940 * c58215a1 Test for #2940Also see attached file that includes both commits.
-
Susan Potter July 23rd, 2009 @ 02:02 AM
Sorry formatting didn't quite work out. Hopefully it makes sense.
-
Susan Potter July 23rd, 2009 @ 02:03 AM
- Title changed from “Rails 2.3.2 changes ActionController "expires_in" API needlessly” to “[PATCH] Rails 2.3.2 changes ActionController "expires_in" API needlessly”
-
Susan Potter July 23rd, 2009 @ 02:24 AM
- Tag changed from “action_controller, caching” to “action_controller, caching, patch”
-
-
Rohit Arondekar October 9th, 2010 @ 03:28 AM
- State changed from “new” to “stale”
- Importance changed from “” to “”
Marking ticket as stale. If this is still an issue please leave a comment with suggested changes, creating a patch with tests, rebasing an existing patch or just confirming the issue on a latest release or master/branches.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Jeremy Kemper
Rohit Arondekar
scott persinger