Rails Ruby on Rails

Comments and changes to this ticket

• 

  CancelProfileIsBroken September 25th, 2009 @ 12:56 PM

  • Tag set to “bugmash”

• You flagged this item as spam.
  

  Elad Meidar September 25th, 2009 @ 11:44 PM

  +1 verified

  if join_table is missing from the macro options, the join table name will be calculated on associations.rb#1596, by using undecorated_table_name (http://apidock.com/rails/ActiveRecord/Base/undecorated_table_name/c....
  This has obviously no reference to the actual table name, if set by set_table_name.

  I tried to patch that line to:
  

  reflection.options[:join_table] ||= join_table_name(self.table_name, reflection.class_name.constantize.table_name)
  

  but reflection.class_name is out of scope in this context, if anyone has any idea how to access/load the association AR::Base class, that would be the key to access the current table name.

• You flagged this item as spam.
  

  Robert Rouse September 26th, 2009 @ 06:44 PM

  +1 verified.

• You flagged this item as spam.
  

  Robert Rouse September 26th, 2009 @ 09:21 PM

  Here is what I've found so far.

  Changing the line at 1596 in associations.rb (as Elad said) to the following does make it appear to work:

  reflection.options[:join_table] ||= join_table_name(undecorated_table_name(self.table_name), undecorated_table_name(reflection.class_name.constantize.table_name))

  I've tried it in a sample Rails app and it returns the right table name no matter which side of the association I use set_table_name on.

  However, this causes the tests in AR to fail with uninitialized constant Project in the belongs_to_association_test.rb file.

  I'm guessing this is what Elad meant before and it working for me is just a funny coincidence.

  I'm still not sure what's up there.

• 

  Anuj Dutta September 26th, 2009 @ 09:54 PM

  Project is the name of one of the models insides the activerecord/test/models directory where has_and_belongs_to_many has been defined and which is used for running the tests. The error basically means that your change has broken something.

• You flagged this item as spam.
  

  Robert Rouse September 26th, 2009 @ 10:06 PM

  andhapp:

  I know what the model is. I'm not sure why it's broken something.

• 

  Rizwan Reza February 12th, 2010 @ 12:46 PM

  • Tag cleared.

  [bulk edit]

• 

  Santiago Pastorino February 2nd, 2011 @ 04:44 PM

  • State changed from “new” to “open”
  • Importance changed from “” to “”

  This issue has been automatically marked as stale because it has not been commented on for at least three months.

  The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

  Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

• 

  Santiago Pastorino February 2nd, 2011 @ 04:44 PM

  • State changed from “open” to “stale”