Rails Ruby on Rails → 3.0.2

Comments and changes to this ticket

• 

  José Valim August 31st, 2009 @ 11:43 PM

  • Assigned user set to “José Valim”

• You flagged this item as spam.
  

  Diego Carrion September 1st, 2009 @ 12:01 AM

  Hi, after some talking, I did refactor the patch.

  • 0001-added-a-default-generator-for-active-model-to-be-use.patch 2.7 KB
• 

  José Valim September 1st, 2009 @ 10:08 AM

  • Milestone cleared.

  Good patch. Just some small changes required:

  1) Tests does not pass. The current test fails (ScaffoldControllerGeneratorTest):

  def test_error_is_shown_if_orm_does_not_provide_interface

  error = capture(:stderr){ run_generator ["User", "--orm=unknown"] }
  assert_equal "Could not load Unknown::Generators::ActiveModel, skipping controller. " <<
               "Error: no such file to load -- generators/unknown.\n", error
  

  end

  It can be removed and replaced by a test that ensures that ORM::Generators::ActiveModel is loaded (instead of Rails::Generators::ActiveModel).

  2) ActiveRecord::Generators::ActiveModel can now be removed.

  Thanks Carrion!

• You flagged this item as spam.
  

  Diego Carrion September 1st, 2009 @ 09:02 PM

  My fault, test were not running correctly in my machine.

  I fixed the test and removed ActiveRecord::Generators::ActiveModel.

  • 0001-added-a-default-generator-for-active-model-to-be-use.patch 4.8 KB

• You flagged this item as spam.
  

  Diego Carrion September 8th, 2009 @ 06:41 PM

  Hi, any feedback on this?

• 

  José Valim September 8th, 2009 @ 07:22 PM

  I need some time to apply it on a fork and add more tests. Showing that no error is raised is not actually testing that an ActiveModel subclass can be loaded.

• You flagged this item as spam.
  

  Diego Carrion September 8th, 2009 @ 09:25 PM

  The test that tests that the code is loaded is the scaffold test. Before the updates, it tested that the ActiveRecord generator was being loaded but that generator doesnt exists anymore, so tests will fail now unless the default generator is being loaded correctly.

• 

  José Valim September 8th, 2009 @ 09:27 PM

  Exactly, so right now, we don't have any test that ensures that ORM::Generators::ActiveModel is loaded, because ActiveRecord is now using the default Rails::Generators::ActiveModel. In other words, we are just testing the fallback.

• 

  Repository October 20th, 2009 @ 02:47 AM

  (from [1f9d234a6b567e68d97e71da6f19bd126e7f7058]) By default use ActiveModel API in controller generators, unless otherwise specified [#3123 status:resolved] http://github.com/rails/rails/commit/1f9d234a6b567e68d97e71da6f19bd...

• 

  José Valim November 1st, 2009 @ 12:16 PM

  • State changed from “new” to “resolved”
• 

  Jeremy Kemper October 15th, 2010 @ 11:01 PM

  • Milestone set to “3.0.2”
  • Importance changed from “” to “”

  [bulk edit]