This project is archived and is in readonly mode.
PostgreSQLAdapter discards parts of ORDER BY clause when eager loading
#3137
add_order_by_for_association_limiting! assumes that you will only use DESC or ASC when ordering rows, but postgres also supports NULLS FIRST and NULLS LAST options.
When using eager loading, something like this named scope...
named_scope :latest_first, :order => "completed_at DESC NULLS LAST"
would actually generate "ORDER BY completed_at".
I've attached an initializer I'm using to monkey-patch the culprit. It's a one line change:
order.map! { |s| $1.upcase if s =~ /\b((asc|desc).*)$/i }
-
Rob Worley- Tag changed from 2.3.2, eager, eagerloading, eager_loading, postgres, postgresql to 2.3.3, eager, eagerloading, eager_loading, postgres, postgresql
-
CancelProfileIsBroken
- Tag changed from 2.3.3, eager, eagerloading, eager_loading, postgres, postgresql to 2.3.3, bugmash, eager, eagerloading, eager_loading, postgres, postgresql
-
Rizwan Reza- State changed from new to open
- Tag changed from 2.3.3, bugmash, eager, eagerloading, eager_loading, postgres, postgresql to 2.3.3, eager, eagerloading, postgres, postgresql
- Milestone set to 2.3.6
Rob, can you provide a failing test patch? Also, if it is not applicable in current Rails versions, do let us know. Thanks!
-
Rizwan Reza
- State changed from open to stale