This project is archived and is in readonly mode.

mysql_adapter.rb redefines all_hashes multiple times under ruby 1.9
Reported by sds | September 7th, 2009 @ 11:31 AM
The instance_methods test in mysql_adapter.rb is not correct as ruby 1.9 returns symbols in instance_methods and not strings.
This simple patch adds an or condition to accept either:
return if target.instance_methods.include?('all_hashes') ||
        target.instance_methods.include?(:all_hashes)
Adding this patch prevents all_hashes being redefined each time a connection is made.
Comments and changes to this ticket
- 
         Repository September 13th, 2009 @ 10:59 AM- State changed from new to committed
 (from [8afeec20e0f664613ddf9e1f965c1d8d5262b8ea]) Ruby 1.9 compat: corrected instance_methods check [#3156 state:committed] Signed-off-by: Jeremy Kemper jeremy@bitsweat.net 
 http://github.com/rails/rails/commit/8afeec20e0f664613ddf9e1f965c1d...
- 
         Repository September 13th, 2009 @ 10:59 AM(from [dbe9fa03dfce54eb2b27341eed924b95e6afbdea]) Ruby 1.9 compat: corrected instance_methods check [#3156 state:committed] Signed-off-by: Jeremy Kemper jeremy@bitsweat.net 
 http://github.com/rails/rails/commit/dbe9fa03dfce54eb2b27341eed924b...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Tags
Referenced by
- 
         3156 
          mysql_adapter.rb redefines all_hashes multiple times under ruby 1.9
        [#3156 state:committed] 3156 
          mysql_adapter.rb redefines all_hashes multiple times under ruby 1.9
        [#3156 state:committed]
- 
         3156 
          mysql_adapter.rb redefines all_hashes multiple times under ruby 1.9
        [#3156 state:committed] 3156 
          mysql_adapter.rb redefines all_hashes multiple times under ruby 1.9
        [#3156 state:committed]
 sds
      sds