This project is archived and is in readonly mode.
Quoting in ActiveRecord::Base is inefficient
-
Comron Sattari
- Tag changed from active to activerecord, active_record, performance
-
Jeremy Kemper
- State changed from new to open
- Assigned user set to Jeremy Kemper
Nice patch! However, it's made against your app's vendor/rails, not Rails itself. Check out the contributor guide for a quick intro to making and submitting changes to Rails: https://rails.lighthouseapp.com/projects/8994/sending-patches
Additional performance work like this is greatly appreciated. Thanks!
-
Marius Nuennerich
Attached is an updated patch against git master. The last part of Comron's patch didn't apply anymore. I actually did another round of optimization in a second commit, maybe you don't want to commit that. Both tested against PostgreSQL, MySQL and Sqlite.
-
Marius Nuennerich
- Tag changed from activerecord, active_record, performance to activerecord, active_record, bugmash-review, performance
-
Rizwan Reza
- Tag changed from activerecord, active_record, bugmash-review, performance to activerecord, active_record, bugmash, performance
-
Jeremy Kemper
Second patch doesn't apply cleanly. It would be nice to keep Comron as an author on the first commit, by the way:
git commit --amend --author "..." -
Marius Nuennerich
Ok, I have redone the first part of the patch with amend.
-
pleax
Verified cache_conn.diff from Marius applies cleanly to master and passes tests on mysql and sqlite3.
-
Jeremy Kemper
Thanks Marius! Could you rebase your second patch also?
-
Repository
- State changed from open to committed
(from [e1a340a91d4ee0bbbe8ce1a74b88b3f7e80c1197]) cache connection when quoting
[#3642 Quoting in ActiveRecord::Base is inefficient state:committed]
Signed-off-by: Marius Nuennerich marius@nuenneri.ch
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/e1a340a91d4ee0bbbe8ce1a74b88b3...
