Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

pleax

pleax

Not a member

pleax's latest activity

Thursday, May 20 2010
4661 Typo in rackup_test.rb was updated in Ruby on Rails
  • pleax
    pleax commented at 10:02 PM

    Opps. Fixed just a few seconds ago :)
    Please close this ticket.
  • pleax
    pleax created the ticket at 9:59 PM

    See patch.
3209 symbol value support for check_box_checked? was updated in Ruby on Rails
  • pleax
    pleax commented at 9:06 PM

    Verified Lena's symbol_check_box.diff agains 2-3 and Enrico's symbol_check_box_for_master2.diff (same patch fixed for master) against master.
    Patches apply clea...
Monday, May 17 2010
3642 Quoting in ActiveRecord::Base is inefficient was updated in Ruby on Rails
  • pleax
    pleax commented at 12:20 AM

    Verified cache_conn.diff from Marius applies cleanly to master and passes tests on mysql and sqlite3.
Sunday, May 16 2010
2919 Activerecord::Base#clone does not set dirty bits was updated in Ruby on Rails
  • pleax
    pleax commented at 11:14 PM

    The patch itself :)
  • pleax
    pleax commented at 10:56 PM

    I've attached patch with bunch of test-cases and my version of fix.
  • pleax
    pleax commented at 2:51 PM

    Last assertion should be assert !cloned_topic.group_changed? offcourse.
  • pleax
    pleax commented at 2:49 PM

    I'm not sure if check for blank? is acceptable here. Because model attributes may have non-empty defaults.

      test "non-empty defaults should not threated as ch...
4154 expires_now broken was updated in Ruby on Rails
  • pleax
    pleax commented at 5:04 PM

    @José Valim: As I can see, tests OdorcicD provided allready in master. And they pass :)
4614 Cloned object mimic changed_attributes from creator after being clonde was updated in Ruby on Rails
  • pleax
    pleax commented at 12:05 PM

    Verified. Reproduces on master.