This project is archived and is in readonly mode.

#4154 ✓ wontfix
Mike Boone

expires_now broken

Reported by Mike Boone | March 11th, 2010 @ 08:42 PM | in 2.3.9

For Rails 2.3.x:

expires_now is supposed to set the Cache-Control header to "no-cache", but the header is overwritten to "private, max-age=0, must-revalidate". I suspect this is happening in actionpack/lib/action_controller/response.rb#set_conditional_cache_control! However, I don't understand the etag stuff well enough to mess with the code in handle_conditional_get! which is calling set_conditional_cache_control!.

Attached is a patch to the tests for expires_now, which fails.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Tickets have moved to Github

The new ticket tracker is available at https://github.com/rails/rails/issues

Shared Ticket Bins

Pages