#4154 expires_now broken - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4154 ✓wontfix

expires_now broken

Reported by Mike Boone | March 11th, 2010 @ 08:42 PM | in 2.3.9

For Rails 2.3.x:

expires_now is supposed to set the Cache-Control header to "no-cache", but the header is overwritten to "private, max-age=0, must-revalidate". I suspect this is happening in actionpack/lib/action_controller/response.rb#set_conditional_cache_control! However, I don't understand the etag stuff well enough to mess with the code in handle_conditional_get! which is calling set_conditional_cache_control!.

Attached is a patch to the tests for expires_now, which fails.

expires_now_test.diff 1.2 KB

Comments and changes to this ticket

You flagged this item as spam.
Mike Boone March 11th, 2010 @ 08:43 PM
- Tag set to “2.3.x, cache-control”
You flagged this item as spam.
Mike Boone March 11th, 2010 @ 08:44 PM
- Tag changed from “2.3.x, cache-control” to “2.3.x, actioncontroller, cache-control”
Jeremy Kemper March 12th, 2010 @ 06:05 AM
- Milestone set to “2.3.6”
- State changed from “new” to “open”
Thanks for the failing test, Mike!
You flagged this item as spam.
Denis Odorcic March 14th, 2010 @ 10:34 AM
- Tag changed from “2.3.x, actioncontroller, cache-control” to “2.3.x, actioncontroller, cache-control, patch”
I've attached a patch for this and the failing test again because the original test had a name conflict.
- expires_now_properly_set_no_cache.diff 2.3 KB
- test_expires_now_properly_set_no_cache.diff 1.4 KB
Rizwan Reza May 16th, 2010 @ 02:41 AM
- Tag changed from “2.3.x, actioncontroller, cache-control, patch” to “2.3.x, actioncontroller, bugmash, cache-control, patch”
[bulk edit]
You flagged this item as spam.
Bastes May 16th, 2010 @ 02:56 PM
+1

Looks good, tests good.
You flagged this item as spam.
Anil Wadghule May 16th, 2010 @ 03:20 PM
+1 Applies cleanly. Test looks good.
Rizwan Reza May 16th, 2010 @ 03:51 PM
- Tag changed from “2.3.x, actioncontroller, bugmash, cache-control, patch” to “2.3.x, actioncontroller, bugmash-review, cache-control, patch”
- State changed from “open” to “verified”
José Valim May 16th, 2010 @ 03:56 PM
Can someone check if this is an issue in Rails 3 (master) as well?
Rizwan Reza May 16th, 2010 @ 04:41 PM
- Tag changed from “2.3.x, actioncontroller, bugmash-review, cache-control, patch” to “2.3.x, actioncontroller, bugmash, cache-control, patch”
Rizwan Reza May 16th, 2010 @ 04:41 PM
- State changed from “verified” to “open”
You flagged this item as spam.
pleax May 16th, 2010 @ 05:04 PM
@José Valim: As I can see, tests OdorcicD provided allready in master. And they pass :)
José Valim May 16th, 2010 @ 05:06 PM
- Tag changed from “2.3.x, actioncontroller, bugmash, cache-control, patch” to “2.3.x, actioncontroller, cache-control, patch”
- Assigned user set to “José Valim”
Jeremy Kemper May 23rd, 2010 @ 05:54 PM
- Milestone changed from “2.3.6” to “2.3.7”
[bulk edit]
Jeremy Kemper May 24th, 2010 @ 09:40 AM
- Milestone changed from “2.3.7” to “2.3.8”
[bulk edit]
Jeremy Kemper May 25th, 2010 @ 11:45 PM
- Milestone changed from “2.3.8” to “2.3.9”
[bulk edit]
You flagged this item as spam.
W. Andrew Loe III June 22nd, 2010 @ 07:58 PM
This will break downloads in IE over SSL.

http://support.microsoft.com/kb/323308

I ran into this when moving to 2.3.8, the headers changed from:

Cache-Control: private, max-age=0, must-revalidate <---- this works

to

Cache-Control: no-cache <--- this is broken.
José Valim June 23rd, 2010 @ 08:13 AM
- State changed from “open” to “wontfix”
Ok, closing. Since applying this on 2.3 (which is a maintenance branch) will definitely break apps for people relying on the wrong behavior