This project is archived and is in readonly mode.
expires_now broken
For Rails 2.3.x:
expires_now is supposed to set the Cache-Control header to "no-cache", but the header is overwritten to "private, max-age=0, must-revalidate". I suspect this is happening in actionpack/lib/action_controller/response.rb#set_conditional_cache_control! However, I don't understand the etag stuff well enough to mess with the code in handle_conditional_get! which is calling set_conditional_cache_control!.
Attached is a patch to the tests for expires_now, which fails.
-
expires_now_test.diff
1.23 KB
-
Mike Boone- Tag set to 2.3.x, cache-control
-
Mike Boone
- Tag changed from 2.3.x, cache-control to 2.3.x, actioncontroller, cache-control
-
Jeremy Kemper- Milestone set to 2.3.6
- State changed from new to open
Thanks for the failing test, Mike!
-
Denis Odorcic- Tag changed from 2.3.x, actioncontroller, cache-control to 2.3.x, actioncontroller, cache-control, patch
I've attached a patch for this and the failing test again because the original test had a name conflict.
-
Rizwan Reza- Tag changed from 2.3.x, actioncontroller, cache-control, patch to 2.3.x, actioncontroller, bugmash, cache-control, patch
-
Bastes+1
Looks good, tests good.
-
Anil Wadghule+1 Applies cleanly. Test looks good.
-
Rizwan Reza
- Tag changed from 2.3.x, actioncontroller, bugmash, cache-control, patch to 2.3.x, actioncontroller, bugmash-review, cache-control, patch
- State changed from open to verified
-
José ValimCan someone check if this is an issue in Rails 3 (master) as well?
-
Rizwan Reza
- Tag changed from 2.3.x, actioncontroller, bugmash-review, cache-control, patch to 2.3.x, actioncontroller, bugmash, cache-control, patch
-
Rizwan Reza
- State changed from verified to open
-
pleax@José Valim: As I can see, tests OdorcicD provided allready in master. And they pass :)
-
José Valim
- Tag changed from 2.3.x, actioncontroller, bugmash, cache-control, patch to 2.3.x, actioncontroller, cache-control, patch
- Assigned user set to José Valim
-
-
-
-
W. Andrew Loe IIIThis will break downloads in IE over SSL.
http://support.microsoft.com/kb/323308
I ran into this when moving to 2.3.8, the headers changed from:
Cache-Control: private, max-age=0, must-revalidate <---- this works
to
Cache-Control: no-cache <--- this is broken.
-
José Valim
- State changed from open to wontfix
Ok, closing. Since applying this on 2.3 (which is a maintenance branch) will definitely break apps for people relying on the wrong behavior