pleax

I added a test and a fix. Please confirm.

Don't see it.

I meant to say in the previous comment that the issue was present in master before my fix.

Agree.

Still not clear to me.

You're trying to say that new objects doesn't treat modified attributes as changed?. But they do:

t = Topic.new :title => 'test'
t.chang...

@elcuervo But it doesn't! As you can see from test-case I provided, some attributes of cloned object behaves differently from new one.

-1 A problem with the patch is illustrated by given test case:

  test "cloned object should threat as changed only modified attributes" do
    token = Topic.ne...

+1

git apply doesn't work for me too. Changes applied by patch tool.
Test-cases are fine, implementation is obvious. All tests pass.

This is not a bug. You can provide translation with following path:

LANG:
  activemodel:
    errors:
      models:
        conversation/message:
          attr...

Could not reproduce either.

+1

Patch applies cleanly, well tested and all tests pass.

I’ve attached a patch with few more test-cases and slightly different approach to implementation.

+1

With updated patch test-cases and implementation seem full and correct for me.