This project is archived and is in readonly mode.
symbol value support for check_box_checked?
Currently it supports booleans, integers, strings and arrays. If the value is casted to symbol (e.g. state_machine does it) check_box helper breaks, trying to invoke to_i on symbol object. The check_box_checked? method should treat symbols like strings.
-
CancelProfileIsBroken- Tag changed from 2.3.4, actionpack, form_helper, patch to 2.3.4, actionpack, bugmash, form_helper, patch
-
Lena HerrmannI've attached a patch based on Jakub's contribution, but adding a test as well.
-
symbol_check_box.diff
2.08 KB
-
-
Pat Allan- I paired with Lena on this commit, so I'm happy to vouch for it. Having symbols treated as strings makes sense in this situation, too.
-
Pat Allan
... and that was a +1, not a numbered list item. Markdown got in the way.
-
Lena Herrmann
- Tag changed from 2.3.4, actionpack, bugmash, form_helper, patch to 2.3.4, actionpack, bugmash, bugmash-review, form_helper, patch
-
Josh Sharpepatch applies to both 2-3 and master.
tests pass+1
-
Elad Meidar
+1 patch applies cleanly on master and 2-3-stable, tests pass as well.
-
qoobaa
-1 for removing the author (thanks) :-)
-
sr.iniv.t
+1 verified.
Patch applies on 2-3-stable. All tests pass.
-
CancelProfileIsBroken
- Tag changed from 2.3.4, actionpack, bugmash, bugmash-review, form_helper, patch to 2.3.4, actionpack, bugmash-review, form_helper, patch
-
Rizwan Reza- Tag changed from 2.3.4, actionpack, bugmash-review, form_helper, patch to 2.3.4, actionpack, bugmash, form_helper, patch
-
Gavin Stark
+1 patch symbol_check_box.diff applies and passes test on rails master @ 3436fdfc12d58925e3d981e0afa61084ea34736c via "patch", but not via "git apply"
-
pleax+1
git applydoesn't work for me too. Changes applied by patch tool.
Test-cases are fine, implementation is obvious. All tests pass. -
Enrico BiancoI've attached Lena's patch, slightly edited so that it'll apply cleanly against the current master branch.
-
symbol_check_box_for_master.diff
2.11 KB
-
-
Enrico Bianco
Oops, messed up the commit message. Let me try that again. >_<
-
pleax
Verified Lena's symbol_check_box.diff agains 2-3 and Enrico's symbol_check_box_for_master2.diff (same patch fixed for master) against master.
Patches apply cleanly. Tests pass. -
Rizwan Reza
- No changes were found…
-
Étienne Barrié
Just like pleax. +1
-
Santiago Pastorino
- State changed from new to open
- Tag changed from 2.3.4, actionpack, bugmash, form_helper, patch to 234, actionpack, bugmash, form_helper, patch
- Importance changed from to Low
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale