Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Étienne Barrié

Étienne Barrié

Not a member

Étienne Barrié's latest activity

Monday, September 27 2010
4891 Rails-2.3.8 db:migrate gives undefined method `length' for :any_index:Symbol was updated in Ruby on Rails
  • Étienne Barrié
    Étienne Barrié commented at 8:06 PM

    The problem this patch was solving (which I am responsible for :( ) was fixed in a few different commits for master / 3-0-stable. First add_index was fixed as I...
Friday, September 24 2010
4891 Rails-2.3.8 db:migrate gives undefined method `length' for :any_index:Symbol was updated in Ruby on Rails
  • Étienne Barrié
    Étienne Barrié commented at 1:44 AM

    James, yes and no. It’s fixed in 3.0.0 and master (7a1bba4799f3fae2c3699816bc071128fd591461 and c0fa4de65b32fc5e8251dafab1330f044d682a1e), but only for add_inde...
Friday, June 25 2010
4891 Rails-2.3.8 db:migrate gives undefined method `length' for :any_index:Symbol was updated in Ruby on Rails
  • Étienne Barrié
    Étienne Barrié commented at 2:44 PM

    Yes it's also present in master. This patch still applies on both 2-3-stable and master and solves that problem.
Friday, June 18 2010
4891 Rails-2.3.8 db:migrate gives undefined method `length' for :any_index:Symbol was updated in Ruby on Rails
  • Étienne Barrié
    • Tag changed from rake db:migrate rails-2.3.8 bug to rake db:migrate rails-2.3.8 bug, patch
    by Étienne Barrié at 3:41 PM

    Thanks for your report. I fixed it in the attached patch. Applies on 2-3-stable but can be cherry-picked to master too.

    Meanwhile, you can just change your symb...
Wednesday, June 16 2010
4809 [PATCH] Table name not escaped on dropping index was updated in Ruby on Rails
  • Étienne Barrié
    Étienne Barrié commented at 8:42 AM

    The conflict appears when you cherry-pick (or rebase --onto) your commits from master to 2-3-stable. But it's just a matter of removing the conflict markers.
Monday, June 14 2010
4809 [PATCH] Table name not escaped on dropping index was updated in Ruby on Rails
  • Étienne Barrié
    Étienne Barrié commented at 1:19 PM

    Paul added the assert_nothing_raised block to remove_index, but not to add_index.
    You added the test to migration_test.rb but in a new TestCase, outside of Migr...
Sunday, June 13 2010
4809 [PATCH] Table name not escaped on dropping index was updated in Ruby on Rails
Friday, May 21 2010
3209 symbol value support for check_box_checked? was updated in Ruby on Rails
4648 Autosave association class names inside tests with nested attributes are misp... was updated in Ruby on Rails
4637 [PATCH] Fix JSON serialization of ActiveModel::Errors was updated in Ruby on Rails
  • Étienne Barrié
    Étienne Barrié commented at 1:46 PM

    What's strange in the patch is that the test is in activemodel while the code change is in activesupport. The change also implies that now all slice operations ...